Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't consume self in ParityTraceBuilder where possible #59

Open
DaniPopes opened this issue Mar 8, 2024 · 1 comment
Open

Don't consume self in ParityTraceBuilder where possible #59

DaniPopes opened this issue Mar 8, 2024 · 1 comment

Comments

@DaniPopes
Copy link
Member

There is no need to and we want to maintain ownership of the struct after in Reth
@DaniPopes DaniPopes changed the title Don't consume self in ParityTraceBuilder Don't consume self in ParityTraceBuilder where possible Mar 8, 2024
@nkysg
Copy link
Contributor

nkysg commented Aug 13, 2024 •
edited
Loading

Do you mean this func

revm-inspectors/src/tracing/builder/parity.rs

Line 265 in 7e31e4f

pub fn into_transaction_traces_iter(self) -> impl Iterator<Item = TransactionTrace> {

Thx @DaniPopes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nkysg @DaniPopes