Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't construct floorbots #52

Closed
Midaychi opened this issue Dec 8, 2014 · 9 comments
Closed

Can't construct floorbots #52

Midaychi opened this issue Dec 8, 2014 · 9 comments
Labels
Bug This is a bug in our game code

Comments

@Midaychi
Copy link
Contributor

Midaychi commented Dec 8, 2014

The step where you put floor tiles onto an empty toolbox doesn't work; it just tells you that you need 10 tiles, then takes 10 tiles away from you. Even if you had 10 or 20 or whatever.

Farmbots are also not constructable, and haven't been for months.
https://github.com/ParadiseSS13/Paradise/blob/master/code/game/machinery/bots/farmbot.dm
I think it might be because line 536,
if ((!istype(S, /obj/item/robot_parts/l_arm)) && (!istype(S, /obj/item/robot_parts/r_arm)))
that should be OR and not &&. The statement is asking for both a right and left arm at the same time.

@Fox-McCloud
Copy link
Member

Farmbots have not been constructable because of their behavior--if I recall correctly they either would not move at all, or their behavior caused runtimes.

Either case, thanks for the info! I'll pass it along.

@Midaychi
Copy link
Contributor Author

Midaychi commented Dec 9, 2014

Found another bot bug (though maybe there was a virus going around? I don't think so).
Medbots will go as if they're going to heal someone, then act like they injected them without actually injecting. This behaviour can be fixed by turning off treat viral infections.

@mvanalphen
Copy link
Contributor

They inject spaceacilin if someone has a disease that's in the database, which is able to cure stage 1 viruses. That should work properly.

@Midaychi
Copy link
Contributor Author

Midaychi commented Dec 9, 2014

Well it doesn't

@mvanalphen
Copy link
Contributor

I tested it locally, and it does. You'll have to provide me with more information than that to get it fixed. Fixing the floorbot issue now.

EDIT: Fixed.

@Midaychi
Copy link
Contributor Author

When on the live server I make a medbot, they will go up to wounded people and go like they're going to inject them, but never actually make the injection animation nor inject them with anything. The only way I can fix this is to disable treating of viral infections.

Pretty sure over the multiple rounds I've tried, the victims weren't infected.

Not sure why its working on your local test server.

@mvanalphen
Copy link
Contributor

I'll give it another try in a few hours.

@Midaychi
Copy link
Contributor Author

Yeah I just tried it a few rounds ago. All I did was make a named medbot, drag it around till I found someone hurt, it went up to them talking like it needed to help them, then immediately acted like it injected them when it didn't. I had to unlock it and disable treating of viral infections to get them to heal the person.

@mvanalphen
Copy link
Contributor

Fixed.

Fox-McCloud added a commit that referenced this issue Jan 18, 2015
@mvanalphen mvanalphen added the Bug This is a bug in our game code label Feb 11, 2015
ghost referenced this issue in ExcidiumStation/ATMTA Jul 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug This is a bug in our game code
Projects
None yet
Development

No branches or pull requests

3 participants