Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version structures for better handling of versions #43

Closed
ionut-arm opened this issue Oct 16, 2019 · 4 comments
Closed

Add version structures for better handling of versions #43

ionut-arm opened this issue Oct 16, 2019 · 4 comments
Labels
bug Something isn't working enhancement New feature or request
Projects

Comments

@ionut-arm
Copy link
Member

Service/protocol versions are used in request/response headers and in the ping operation.

At the moment these values are stored as two separate integers. It would be helpful if:

  • They were represented by a Version object
  • We had an explicit agreement on how to handle a difference between the version of a backend handler and the version specified in a request header handled by it.
@ionut-arm ionut-arm added bug Something isn't working enhancement New feature or request labels Oct 16, 2019
@ionut-arm ionut-arm added this to To do in Parsec via automation Oct 16, 2019
@hug-dev
Copy link
Member

hug-dev commented Feb 13, 2020

Please see #105 for more information on versioning.

@hug-dev
Copy link
Member

hug-dev commented Feb 25, 2020

The second point of this issue has been adressed by #105. Renaming it "Add a Version objects" to handle the replacement of our minor/major/rev versions by those richer structures.

@hug-dev hug-dev changed the title Fix version handling for the ping operation Add version structures for better handling of versions Feb 25, 2020
@ionut-arm
Copy link
Member Author

Part of this was solved by parallaxsecond/parsec-interface-rs#41 . But we do need to figure out the bigger picture of handling different wire protocol versions within the client and the service.

@hug-dev
Copy link
Member

hug-dev commented Dec 11, 2020

The big picture of version handling should be adressed by #169

@hug-dev hug-dev closed this as completed Dec 11, 2020
Parsec automation moved this from All issues to Done Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
Development

No branches or pull requests

2 participants