-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Node, Browsers, WebWorkers, & ReactNative #68
Comments
Do you know what kind of problem keeping different versions has been? The adhoc |
Fair point. I'm not actually picky about whether or not there are separate builds. Just that we support everything that needs supporting. Ideally, we can find entropy sources that work everywhere, but that shouldn't be a strict requirement. |
Sorry to keep questioning: seeing if I can help clean this up / modernize in the best way. Re. linting / code style, the older source files used a different code style and lint settings that the new files. I see from #31 that you prefer custom eslint over standard. I should format the code to match the current I see the newer code is written in ES2016 and is transformed with babel. I see no need for this for a module like this, it just increases the barrier for contributors, adds an additional build step, and increases code size. Any preferences here? Happy to stay in ES2016 too if preferred. Finally what browser versions should this target? I see the latest |
This module is small/simple enough that ES5 + node-style modules is fine. IE >= 9 + all major current browsers (including mobile Safari) is fine. |
The JS version of cuid needs to support all of these targets:
We'll use feature detection to select the correct entropy source and return the right
fingerprint()
function for the environment.Ideally, we should select entropy sources supported by all of the above environments.
The text was updated successfully, but these errors were encountered: