Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement v2 #103

Closed
21 of 22 tasks
kennylavender opened this issue May 12, 2018 · 4 comments
Closed
21 of 22 tasks

Implement v2 #103

kennylavender opened this issue May 12, 2018 · 4 comments
Assignees

Comments

@kennylavender
Copy link
Contributor

kennylavender commented May 12, 2018

Following the proposal outlined in #102

Implement update the following:

  • Update Readme
  • Components
    • FeatureToggles
    • Feature
  • HOCs
    • withFeatureToggles
    • configureFeature
  • Functions
    • isActive
    • mergeFeatures
    • deactivateFeatures
    • parseQuery
    • getEnabledFeatures
    • getBrowserQueryFeatures
    • getReqQueryFeatures
  • Update Feature Interface
  • Remove old code
    • components
    • hocs
    • functions
    • tests
  • Update createRouteMiddleware

After these are implemented, we need to build more automation of query parsing and merging of features.

@kennylavender
Copy link
Contributor Author

I've done all the PR's I am going to do for now, I want Jesse, once he accepts, to review the current PR's and Pair Program with me on the rest of the v2 changes.

@kennylavender
Copy link
Contributor Author

Note to self: after implementing getBrowserQueryFeatures and getReqQueryFeatures it might make sense to rename parseQuery to getQueryFeatures

@ericelliott
Copy link
Contributor

What needs to be done to get 2.0 out of beta?

@kennylavender
Copy link
Contributor Author

I think everything is done except reviewing the express middleware to see if we can make improvements. I've updated the list above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants