Add database connection helper

[patcon]

Addresses #56

As mentioned in that issue, this is to simplify wrapper cookbooks.

[bflad]

Please fix Rubocop whitespace and tell it to ignore other error, then LGTM.

[legal90]

@patcon It looks good!

Let's move the default port management to this new confluence_database_connection helper?
https://github.com/bflad/chef-confluence/blob/master/libraries/helpers.rb#L50-L57

[patcon]

Thanks :)

Would it not make sense that the order of derivation is as follows:

node >> merged_confluence_settings >> confluence_database_connection

node (just attributes)
merged_confluence_settings (attributes + databag)
confluence_database_connection (high-level helper for settings data)

Mixing that up could lead to wonky unexpected behaviour in some use-cases. Like it someone sets database type in the databag, and the conf database connection helper isn't using settings as the source of truth.

Sorry, maybe I'm being pedantic :) I don't even use the databag feature, but it seems settings should have all the data it can be easily loaded with :)

EDIT: Heh. On second thought, it's all good. I'll make your suggested change later :)

[legal90]

Oh, yeah. It sounds reasonable. Then let it be as is.

Please, fix the Rubocop warnings

[patcon]

Ah, lost track of this, but fixed the rubocop errors. Should be good to merge :)

[patcon]

Testing cleanly against standalone-postgresql-ubuntu-1404 and standalone-mysql-ubuntu-1404

[legal90]

@patcon Thanks!

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.