Use helper functions for host-related attributes that are currently derived #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patcon
changed the title
patcon
added a commit
to patcon/chef-confluence
that referenced
this pull request
Nov 17, 2015
patcon
force-pushed
the
81-fqdn-hostname-helpers
branch
from
4adf6a6
to
5fc77b7
Compare
|
👍 |
|
Looks good, thank you! |
legal90
added a commit
that referenced
this pull request
Nov 18, 2015
Use helper functions for host-related attributes that are currently derived
legal90
added a commit
that referenced
this pull request
Feb 19, 2016
* master: (27 commits) Run integration tests in Travis with Docker .kitchen.yml: Remove "ubuntu-15.04" platform support Add fixture cookbook Use ChefDK for running Rake tasks and Travis jobs Update contribution and testing guidelines according to Chef Software conventions test/integration: Use "infrataster" to check website availability Converted virtualhost derived attrs into helper functions. [#81] Add support of Confluence 5.8.16 spec/database_spec: Fix data bag item Add spec for "database" recipe Add apt cookbook for test-kitchen success on DO. Allow helpers to be used within resource. Fixed rubocop errors. Removed redundant var. Added database connection helper. Set postgres db owner, and remove :grant action. [#54] Mark 'java' cookbook as a dependency Update README.md Allow to override SSO settings in the data bag Fix README.md Use common method "data_bag_item" for item loading ...
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're currently using derived attributes for
virtual_host_aliasandvirtual_host_name, which makes it cumbersome to deploy on some platforms where the hostname needs to be set. This PR ensures that FQDN and hostname can be set, and our attributes inherit as expected.