Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

invoke updating cluster health based on the dialin connection #108

Merged
merged 2 commits into from
Feb 28, 2024
Merged

invoke updating cluster health based on the dialin connection #108

merged 2 commits into from
Feb 28, 2024

Conversation

niravparikh05
Copy link
Contributor

@niravparikh05 niravparikh05 commented Feb 12, 2024 •
edited
Loading

What does this PR change?

Does the PR depend on any other PRs or Issues? If yes, please list them.

Checklist

I confirm, that I have...

  • Read and followed the contributing guide in CONTRIBUTING.md
  • Added tests for this PR
  • Formatted the code using go fmt (if applicable)
  • Updated documentation on the Paralus docs site (if applicable)
  • Updated CHANGELOG.md

@niravparikh05
invoke updating cluster health based on the dialin connection
89b957e 
Signed-off-by: niravparikh05 <nir.parikh05@gmail.com>
@niravparikh05 niravparikh05 mentioned this pull request Feb 12, 2024
Merged
5 tasks
akshay196
akshay196 requested changes Feb 23, 2024
View reviewed changes
Copy link
Member

@akshay196 akshay196 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor review comments -

pkg/tunnel/healthz.go Show resolved Hide resolved
pkg/tunnel/healthz.go Show resolved Hide resolved
pkg/tunnel/healthz.go Show resolved Hide resolved
pkg/tunnel/healthz.go Show resolved Hide resolved
@niravparikh05
added return from healthz during errors
b9a78de 
Signed-off-by: niravparikh05 <nir.parikh05@gmail.com>
@niravparikh05 niravparikh05 merged commit 47e3f14 into main Feb 28, 2024
5 checks passed
@niravparikh05 niravparikh05 deleted the cluster-healthz branch February 28, 2024 05:12
@niravparikh05 niravparikh05 added this to the v0.1.7 milestone Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akshay196 akshay196 akshay196 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.1.7
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@niravparikh05 @akshay196