Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

documentation request: explain that Transport.open_channel src_addr is merely advisory #1485

Open
eichin opened this issue Jul 26, 2019 · 0 comments

Comments

@eichin
Copy link

eichin commented Jul 26, 2019

Was attempting to set up a simple one-shot forward and forward.py looked a bit complex so I thought I could just work with the open_channel docstring. I was misled by the source address (in the direct-tcpip case specifically) because I assumed that it was actually used - if it actually said in the docstring that it was only so that remote server could produce more useful logs (an assumption on my part, but since it's user specified the server can't possibly be trusting it for anything, right?) I would have more quickly realized that setting up the listening socket was entirely my problem, and that this call isn't to set up forwarding, merely to ask for the far side of the connection to happen.

(In retrospect, it's "obvious" and the complexity in forward.py makes sense - but even after not finding any listening code in transport.py, it still took a while for "what was actually going on" to sink in, and it wouldn't take much of a hint to help out here. A real bonus would be explaining which calls handle which parts of the -L and -R openssh command line arguments, but just a sentence or two about src_addr would have saved me hours.)

#1410 is sort of related.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant