Match Still Confusing Paramiko SSH Config Parsing

[callegar]

It is my understanding that the OpenSSH match keyword should now be supported after the closing of issue #717 .

However, I am still experiencing issues with it.

Specifically, I am trying to work with xpra (https://xpra.org/) which uses an ssh channel for providing a persistent remote display server and client for forwarding applications and desktop screens. In turn xpra relies on paramiko for its ssh connection.

With paramiko 2.7.1 even something simple as xpra attach ssh:localhost:101 (which should ssh to localhost and attach there to display :101) fails with the following error:

2020-07-29 09:57:06,245 Warning: failed to connect:
2020-07-29 09:57:06,246  connection failed: 'host'

Removing the match sections in the config file (which incidentally should never do anything with localhost) appears to clear the issue.

Using paramiko 2.6.0 seems to also avoid the issue, but it is unclear to me if that version of paramiko should have support for match at all, plus it has issues for other reasons such as problems with ssh keys being in their own format rather than PEM.

To break things, it is enough for the ssh config file to contain something as simple as

Match host blahblah

at the end.

[callegar]

Issue #1674 seems related as the pull request mentioned there appears to fix the issue.

[MrMino]

The second line of the log seems like the message from a KeyError, #1674 might be exactly the fix.