Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It appears that join() is never actually called in Transport.stop_thread() #2185

Open
ni-balexand opened this issue Feb 10, 2023 · 1 comment

Comments

@ni-balexand
Copy link

As part of my investigation into #2184, I figured it would probably be worthwhile to look around the paramiko package to get an understanding for how it works / what might be happening.

Something that stood out to me was, as mentioned in the title, it appears that join() is never actually called in Transport.stop_thread().

See my comment here:

0e54d0f#r100015464

I only noticed this when reading over the code, I don't know if this is actually related to the crash I'm seeing. bskinn suggested that I submit a new issue on this topic.

@bskinn
Copy link
Contributor

bskinn commented Feb 10, 2023

Thanks for the report, @ni-balexand!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants