Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle smaller amounts for automatic exchange in XCM Router #237

Closed
dudo50 opened this issue May 23, 2024 · 0 comments · Fixed by #263
Closed

Handle smaller amounts for automatic exchange in XCM Router #237

dudo50 opened this issue May 23, 2024 · 0 comments · Fixed by #263
Labels
enhancement New feature or request maintenance work XCM ROUTER Issue is about XCM Router

Comments

@dudo50
Copy link
Contributor

dudo50 commented May 23, 2024

We are currently handling the situation with manual swap chain selection. If the user wants to swap an amount that will result in a negative amount we give an error. But, this happens on the swap chain only. During the automatic exchange it would be nice to handle this before the first xcm message is sent to ensure the best UX.
@dudo50 dudo50 added enhancement New feature or request maintenance work labels May 23, 2024
@dudo50 dudo50 added being worked on XCM ROUTER Issue is about XCM Router labels Jun 7, 2024
@dudo50 dudo50 changed the title XCM ROUTER: Handle smaller amounts for automatic exchange in XCM Router Handle smaller amounts for automatic exchange in XCM Router Jun 7, 2024
@michaeldev5 michaeldev5 linked a pull request Jun 20, 2024 that will close this issue
fix(xcm-router): Fix handling small amounts before sending XCM to exc… #263
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request maintenance work XCM ROUTER Issue is about XCM Router
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(xcm-router): Fix handling small amounts before sending XCM to exc… paraspell/xcm-tools
1 participant
@dudo50