Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention requirement to set alpha channel in changelog for 0.9 #305

Closed
LukasKalbertodt opened this issue Sep 4, 2022 · 2 comments
Closed
Labels
documentation Improvements or additions to documentation

Comments

@LukasKalbertodt
Copy link

Hi there! Really awesome library, thanks for maintaining it!

I just updated a project of mine from 0.3 to 0.9 by doing each intermediate updated individually. Everything just worked till 0.8, but updating from 0.8 to 0.9 suddenly resulted in a completely black screen. I finally found out that the issue was that I never wrote to the alpha channel. But for the previous pixel versions that was fine. But with 0.9 I had to manually write 255 to the alpha channel of each pixel at least once.

I could imagine that I was always supposed to write the alpha channel. But since it has become required since 0.9, maybe consider mentioning this in the changelog. Could save some others some time.

@parasyte
Copy link
Owner

parasyte commented Sep 4, 2022

👋 Thanks for the report and kind words.

There is a line in the changelog for the feature:

Make the background/border color configurable, and support basic alpha blending (#236)

You're right that it should also mention the breaking change with the new default BlendState from that change which enabled alpha blending. I'll just go ahead and make that update now.

@parasyte parasyte added the documentation Improvements or additions to documentation label Sep 4, 2022
@parasyte parasyte closed this as completed Sep 4, 2022
@LukasKalbertodt
Copy link
Author

Thanks a lot for the quick fix :) Looks good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants