Skip to content
This repository has been archived by the owner on Nov 15, 2022. It is now read-only.

Typescript #12

Closed
danielkcz opened this issue Mar 26, 2019 · 5 comments
Closed

Typescript #12

danielkcz opened this issue Mar 26, 2019 · 5 comments
Labels
wontfix This will not be worked on

Comments

@danielkcz
Copy link

@Paratron I assume you are not TypeScript user, but many TS users would appreciate having types available.

The best course of action is, of course, have the source in TypeScript. It can compile to clean JS a similar way as Babel can. Or you can even use Babel to compile and TypeScript to extract typings only.

Otherwise, it means to manually synchronize types for every API change.

I can help with either way.

@Paratron
Copy link
Owner

Paratron commented Mar 26, 2019

I will absolutely and never ever change this project to TypeScript. I am a strong opposer to using TypeScript at all.

If anyone thinks this project needs typings, he/she is free to contribute to the @types collection.

@Paratron Paratron added the wontfix This will not be worked on label Mar 26, 2019
@danielkcz
Copy link
Author

danielkcz commented Mar 26, 2019

Such hostile tone was unnecessary 😕 It was a legit question. If you dislike it so much, it's your choice, but there are people loving it. It's almost a question of religion...

Cool beans, I will just make types for my use and possibly share in here. I don't like DefinitelyTyped ecosystem.

@danawoodman
Copy link

Man, this is unfortunate... If anyone has the time to do the type defs, that would be amazing!

In the meantime, you can create a file hookrouter.d.ts and include:

declare module 'hookrouter'

... to suppress errors but it won't get you any type checking.

@mcaneris
Copy link

I have created types for this package.

Linking pull request to DefinitelyTyped for those interested: #35443

@Paratron
Copy link
Owner

Thanks for creating the dype definitions - I will mention them in the README.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

4 participants