Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Time-based invalidation of debug information caches #275

Closed
kakkoyun opened this issue Mar 3, 2022 · 3 comments · Fixed by #282
Closed

Time-based invalidation of debug information caches #275

kakkoyun opened this issue Mar 3, 2022 · 3 comments · Fixed by #282
Assignees
@kakkoyun
Labels
enhancement New feature or request

Comments

@kakkoyun
Copy link
Member

kakkoyun commented Mar 3, 2022

No description provided.

@kakkoyun kakkoyun added the enhancement New feature or request label Mar 3, 2022
@kakkoyun kakkoyun self-assigned this Mar 3, 2022
@brancz
Copy link
Member

brancz commented Mar 3, 2022

Why time-based? I've always found size- or count-based to be more predictable for users in practice.

@kakkoyun
Copy link
Member Author

kakkoyun commented Mar 5, 2022

I should have more specific. I specifically meant debug info exists response cache. Now that we have another way to find debug information, it would be more correct to invalidate local cache.

@brancz
Copy link
Member

brancz commented Mar 7, 2022

Ah, that makes perfect sense, yes! We probably have to also differentiate between the result of the response.

@kakkoyun kakkoyun mentioned this issue Mar 15, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kakkoyun kakkoyun

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add TTL to exists response cache kakkoyun/parca-agent
2 participants
@kakkoyun @brancz