Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IntoOwned as a trait, and implement it for nodes when R implements IntoOwned #596

Closed
kdy1 opened this issue Oct 6, 2023 · 1 comment · Fixed by #597
Closed

IntoOwned as a trait, and implement it for nodes when R implements IntoOwned #596

kdy1 opened this issue Oct 6, 2023 · 1 comment · Fixed by #597

Comments

@kdy1
Copy link
Contributor

kdy1 commented Oct 6, 2023

@devongovett Will you accept a PR for this?
If so, which crate should have IntoOwned?

@devongovett
Copy link
Member

I think I originally tried to implement it as a trait and couldn't get it to work but I can't remember why. But if you get it working that sounds good to me. We can put the trait in here https://github.com/parcel-bundler/lightningcss/blob/master/src/traits.rs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants