You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Very cool. Would you like to make a PR to add that to core? I think it will be much easier to maintain there without depending on the internal implementation details of HTMLAsset in a plugin.
Sure, but there's a critical issue that needs fixing first (and I'm not really sure how to do it): paths aren't allowed, only full URLs. How can Parcel deal with it ?
I did think about a possible workaround:
Assume the user will enter a valid URL (warn otherwise)
When parsing the schema, extract the path and treat it as any local path
https://github.com/parcel-bundler/parcel/blob/master/src/assets/HTMLAsset.js#L64 JSON is skipped. I know schema.org specs are quite extensive but there are a few basics: image / logo for assets.
🙋 feature request
Assets used in JSON-LD schemas aren't added to the dependency tree. And as a result are missing from builds.
🤔 Expected Behavior
A minimal subset of the attributes should be included in parcel, just like it was done with Open Graph, etc: #747
😯 Current Behavior
Nothing happens since
application/ld+json
scripts aren't recognized.💁 Possible Solution
Parse JSON, fetch attributes that match a list (almost the same as #747) and finally add them as dependencies.
💻 Examples
The text was updated successfully, but these errors were encountered: