Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit asset nodes on subsequent builds after symbol error #7337

Merged
merged 2 commits into from
Nov 23, 2021

Conversation

mischnic
Copy link
Member

Closes #7272

Mark asset node as dirty when a symbols error was determined for in that asset. This ensures that the node will be revisited on the next run (especially on no-change rebuilds) so that the error can be rethrown.

@height
Copy link

height bot commented Nov 20, 2021

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@parcel-benchmark
Copy link

Benchmark Results

Kitchen Sink ✅

Timings

Description Time Difference
Cold 1.76s -31.00ms
Cached 258.00ms -1.00ms

Cold Bundles

No bundle changes detected.

Cached Bundles

Bundle Size Difference Time Difference
dist/legacy/parcel.7cdb0fad.webp 102.94kb +0.00b 521.00ms -29.00ms 🚀
dist/legacy/parcel.7cdb0fad.webp 102.94kb +0.00b 522.00ms -29.00ms 🚀
dist/modern/parcel.7cdb0fad.webp 102.94kb +0.00b 522.00ms -29.00ms 🚀

React HackerNews ✅

Timings

Description Time Difference
Cold 9.06s -9.00ms
Cached 397.00ms -4.00ms

Cold Bundles

Bundle Size Difference Time Difference
dist/logo.c5bb83f1.png 246.00b +0.00b 4.24s -595.00ms 🚀

Cached Bundles

No bundle changes detected.

AtlasKit Editor ✅

Timings

Description Time Difference
Cold 59.61s +146.00ms
Cached 1.39s +23.00ms

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

Three.js ✅

Timings

Description Time Difference
Cold 6.26s +40.00ms
Cached 310.00ms +12.00ms

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

Click here to view a detailed benchmark overview.

@devongovett devongovett merged commit 3120998 into v2 Nov 23, 2021
@devongovett devongovett deleted the 7272-export-error-cache branch November 23, 2021 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build fails when cache is empty, and succeeds next time ("does not export")
3 participants