Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing imports for external dependencies in skipped assets #8299

Merged
merged 1 commit into from Jul 12, 2022

Conversation

devongovett
Copy link
Member

A library with sideEffects: false might have a re-export of an external dependency. If this dependency was in a skipped asset, the external import was never added, resulting in a $id$re_export$foo is not defined error at the export site. This makes sure to add dependencies of a skipped asset as externals when not resolved.

@parcel-benchmark
Copy link

Benchmark Results

Kitchen Sink ✅

Timings

Description Time Difference
Cold 1.51s +22.00ms
Cached 339.00ms -4.00ms

Cold Bundles

No bundle changes detected.

Cached Bundles

Bundle Size Difference Time Difference
dist/legacy/index.2c76ad23.js 1.66kb +0.00b 427.00ms -23.00ms 🚀
dist/legacy/index.8aaa89c9.js 1.20kb +0.00b 428.00ms -22.00ms 🚀

React HackerNews ✅

Timings

Description Time Difference
Cold 9.24s +22.00ms
Cached 459.00ms +9.00ms

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

AtlasKit Editor ✅

Timings

Description Time Difference
Cold 1.61m -1.06s
Cached 2.58s -38.00ms

Cold Bundles

Bundle Size Difference Time Difference
dist/esm.c7dc1640.js 61.96kb +0.00b 1.20m +32.00s ⚠️
dist/workerHasher.e50d242f.js 1.72kb +0.00b 1.20m +32.00s ⚠️
dist/16.1969624f.js 1.08kb +0.00b 38.79s +2.76s ⚠️
dist/index.html 240.00b +0.00b 1.20m +37.12s ⚠️

Cached Bundles

No bundle changes detected.

Three.js ✅

Timings

Description Time Difference
Cold 6.67s -5.00ms
Cached 288.00ms +14.00ms

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

Click here to view a detailed benchmark overview.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants