Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

better error handling #7

Closed
devongovett opened this issue Apr 1, 2019 · 0 comments
Closed

better error handling #7

devongovett opened this issue Apr 1, 2019 · 0 comments

Comments

@devongovett
Copy link
Member

There are a bunch of C++ throw statements floating around in the code which aren't currently caught and passed back to JS. We should do that somehow. May require an API change for subscribe to add an error argument to the callback. For other APIs, errors should apply to the promise.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@devongovett