New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide docker image for cargo-contract #184
Comments
related to #125 |
maybe it would make more sense to work on the custom CI image we update and test every day against this project instead of creating a new one? |
@TriplEight makes sense to me, feel free to close my PR if that is what y'all end up doing. |
@trace-andreason contributions are always welcome, the project I linked is also open source. It stores our CI images and automates their update every night, the CI image for contract (docker.io/paritytech/contracts-ci-linux:production) also lives there, please feel free to add to it. |
@TriplEight you were right about the binaryen version in the image I was working on not being quite enough to build a contract. Like you said I don't see a reason for having a separate image if there already is an official image y'all use for CI. It might be nice to have a link to that image somewhere in the readme |
@trace-andreason this is a great point, we'll add it to the readme. |
For substrate runtime, parity uses srtool(https://github.com/paritytech/srtool) to compile wasm. And Solang as well, providing a docker image which contrains newest Solang. (https://github.com/hyperledger-labs/solang/blob/main/Dockerfile)
And we think cargo-contract could also provide such docker image. This docker image could resolve the following things:
cmake
by default, thus, windows users need to parparecmake
before install. If using docker, windows users do not need to install cmake.Thus, we help cargo-contract provides a docker image by default.
The text was updated successfully, but these errors were encountered: