Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advise adding commit hash info in version #188

Closed
atenjin opened this issue Feb 20, 2021 · 2 comments
Closed

Advise adding commit hash info in version #188

atenjin opened this issue Feb 20, 2021 · 2 comments

Comments

@atenjin
Copy link
Contributor

atenjin commented Feb 20, 2021

Similar to solc or Substrate, when someone execute --version, would contains the commit hash info:

-->$ solc --version
solc, the solidity compiler commandline interface
Version: 0.8.1+commit.df193b15.Linux.g++
-->$ ./target/debug/polkadot --version
polkadot 1.0.0-2ca35c3-x86_64-linux-gnu

Currently, cargo-contract has not released next version, and we (Redspot) need those features. So we advice to add the commit hash info for our 3rd parites to distinguish whether this cargo-contract is from crates.io or github master. Thanks.

@atenjin atenjin changed the title Advise add commit hash info in version Advise adding commit hash info in version Feb 20, 2021
@atenjin
Copy link
Contributor Author

atenjin commented Feb 20, 2021

I have summit pr #189 for this

@cmichi
Copy link
Collaborator

cmichi commented Apr 15, 2021

Closing the issue now since we have merged the PR a while ago.

@cmichi cmichi closed this as completed Apr 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants