Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dry-run result output improvements #1123

Merged
merged 6 commits into from
Jun 13, 2023
Merged

Dry-run result output improvements #1123

merged 6 commits into from
Jun 13, 2023

Conversation

ascjones
Copy link
Collaborator

Instantiate

  • Replace useless "Success!" field with actual decoded data (it will be the decoded Result<Result<(), _>>).

Before:
image

After (The Bytes has now been decoded into Ok())
image

Call

Similarly, replaced the useless "Success!" with the decoded data.

Before:
image

After:
image

cmichi
cmichi approved these changes Jun 13, 2023
View reviewed changes
Copy link
Collaborator

@cmichi cmichi left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coolio! CHANGELOG.md would be good.

@ascjones ascjones merged commit 71a8a42 into master Jun 13, 2023
11 checks passed
@ascjones ascjones deleted the aj/fix-instantiate-data branch June 13, 2023 16:18
This was referenced Jul 26, 2023
Merged
Merged
@smiasojed smiasojed mentioned this pull request Mar 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmichi cmichi cmichi approved these changes

@agryaznov agryaznov agryaznov approved these changes

@HCastano HCastano Awaiting requested review from HCastano

@SkymanOne SkymanOne Awaiting requested review from SkymanOne

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ascjones @cmichi @agryaznov