Add encode command
#998
Add encode command
#998
Conversation
| let transcoder = artifacts.contract_transcoder()?; | ||
|
|
||
| let call_data = transcoder.encode(&self.message, &self.args)?; | ||
| let call_data_encoded = hex::encode_upper(call_data); |
There was a problem hiding this comment.
Why have you chosen to use upper case hex? I don't mind it, but we should be mindful of consistency where we have used hex::encode in other places. If uppercase hex is preferable we should have it everywhere, I have never considered the pros and cons before though.
There was a problem hiding this comment.
Because that's how we specify custom selectors in tests in examples
There was a problem hiding this comment.
True, but this is showing the whole encoded message not just the selector.
It seems to be a matter of taste whether hex values are preferred to be expressed as upper or lowercase. I don't really have an opinion, I just think it should be consistent within this tool. So if we prefer upper case hex representation of bytes then we should do that everywhere (in cargo-contract). Because previously the default was plain hex::encode which does lowercase.
There was a problem hiding this comment.
I did it in other places too
There was a problem hiding this comment.
I can still find a few other places with hex::encode though (okay we don't want to change it for the LowerHex impls. It doesn't matter that much in the end though. Just nice to be consistent.
Closes #986
Some changes:
contract_artifacts()in extrinsics into a separate public functionfind_contract_artifacts()because we need it in order to retrieve the metadata, butExtrinsicOptsalso require--surito be specified that we don't need for encoding.