Skip to content
This repository has been archived by the owner on Nov 11, 2022. It is now read-only.

Remove parachains mentions from Substrate repository #298

Closed
tomusdrw opened this issue Sep 23, 2021 · 3 comments · Fixed by paritytech/substrate#10664
Closed

Remove parachains mentions from Substrate repository #298

tomusdrw opened this issue Sep 23, 2021 · 3 comments · Fixed by paritytech/substrate#10664
Labels
enhancement New feature or request M-runtime R-substrate The issue has to be implemented in the Substrate repo

Comments

@tomusdrw
Copy link
Contributor

Re: paritytech/substrate#9833 (comment)

The beefy-mmr pallet contains now functions and fields specific to parachains, hence it does not necessarily fit Substrate repository.

IMHO the best way forward with this would be to generalize parachains to something like "leaf extra data". This extra data would have it's own Provider passed in Config. The data returned by Provider can have two flavors:

  1. A single blob - include as is.
  2. A collection - merkelize and include hash in the leaf.
@tomusdrw tomusdrw added enhancement New feature or request R-substrate The issue has to be implemented in the Substrate repo M-runtime labels Sep 23, 2021
@seunlanlege
Copy link

seunlanlege commented Nov 15, 2021

This makes sense, we could just call it extras and have it be a simple blob of bytes with a bounded len?

@tomusdrw
Copy link
Contributor Author

I think beefy-mmr should probably be moved to polkadot repository since it contains payload that is specific to polkadot. I'd also suggest to extract primitives that are beefy-mmr/polkadot specific, like concrete MmrLeaf.

@acatangiu
Copy link
Collaborator

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request M-runtime R-substrate The issue has to be implemented in the Substrate repo
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants