Explicitly link against rlibc to get non buggy version of memcpy #1049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1049 +/- ##
===========================================
- Coverage 78.78% 63.76% -15.03%
===========================================
Files 248 248
Lines 9363 9361 -2
===========================================
- Hits 7377 5969 -1408
- Misses 1986 3392 +1406
Continue to review full report at Codecov.
|
|
I wonder what effects this has on the Wasm file sizes and compilation times but I guess |
|
I guess file sizes in this PR will get up because I re-enabled overflow-checks. But look at this crate. It is tiny. |
🦑 📈 ink! Example Contracts ‒ Size Change Report 📉 🦑These are the results of building the
Link to the run | Last update: Thu Nov 25 12:11:44 CET 2021 |
tash-2s
added a commit
to tash-2s/open-emoji-battler
that referenced
this pull request
Jan 16, 2022
xgreenx
pushed a commit
to Supercolony-net/ink
that referenced
this pull request
Feb 8, 2022
…-ink#1049) * Explicitly link against rlibc to get non-buggy version of memcpy * Revert "Disable overflow checks for examples (use-ink#1034)" This reverts commit b2256d9.
This was referenced Mar 2, 2022
forbesus
added a commit
to forbesus/OpenEmojiBattler
that referenced
this pull request
Feb 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #364
The "ghost import" is called by the compiler inserted
memcpyfunction. This is a workaround by providing a non buggy version of this functions ourselves.