Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump secp256k1 #1348

Merged
merged 1 commit into from
Aug 4, 2022
Merged

Bump secp256k1 #1348

merged 1 commit into from
Aug 4, 2022

Conversation

athei
Copy link
Contributor

@athei athei commented Aug 4, 2022

This dep is out of date with substrate. Not sure why dependabot doesn't pick it up. Maybe because it is guarded behind an arch?

@cmichi cmichi merged commit c4c0283 into master Aug 4, 2022
@cmichi cmichi deleted the at/update-secp256k1 branch August 4, 2022 10:23
@jasl
Copy link

jasl commented Aug 7, 2022

Could you made a release?
it blocks the upgrade to polkadot-v0.9.27

@jasl
Copy link

jasl commented Aug 7, 2022

Or better backport to v3.x.x branch maybe?

@HCastano
Copy link
Contributor

HCastano commented Aug 8, 2022

Ah shit, yeah I closed it without thinking much about it #1332 🙈

jasl pushed a commit to jasl/ink that referenced this pull request Aug 8, 2022
@HCastano
Copy link
Contributor

HCastano commented Aug 8, 2022

Could you made a release? it blocks the upgrade to polkadot-v0.9.27

@jasl can you share what you're doing here and how/why it breaks?

HCastano pushed a commit that referenced this pull request Aug 8, 2022
@HCastano HCastano mentioned this pull request Aug 8, 2022
@jasl
Copy link

jasl commented Aug 8, 2022

Could you made a release? it blocks the upgrade to polkadot-v0.9.27

@jasl can you share what you're doing here and how/why it breaks?

error: failed to select a version for `secp256k1-sys`.
    ... required by package `secp256k1 v0.22.0`
    ... which satisfies dependency `secp256k1 = "^0.22.0"` of package `ink_env v3.1.0`
    ... which satisfies dependency `ink_env = "^3.1.0"` of package `pink-extension v0.1.13 (/Users/jasl/Workspaces/BlockChain/phala-blockchain/crates/pink/pink-extension)`
    ... which satisfies path dependency `pink-extension` of package `pink v0.1.0 (/Users/jasl/Workspaces/BlockChain/phala-blockchain/crates/pink)`
    ... which satisfies path dependency `pink` of package `phactory v0.0.1 (/Users/jasl/Workspaces/BlockChain/phala-blockchain/crates/phactory)`
    ... which satisfies path dependency `phactory` of package `replay v0.1.0 (/Users/jasl/Workspaces/BlockChain/phala-blockchain/standalone/replay)`
versions that meet the requirements `^0.5.0` are: 0.5.2, 0.5.1, 0.5.0

the package `secp256k1-sys` links to the native library `rustsecp256k1_v0_5_0`, but it conflicts with a previous package which links to `rustsecp256k1_v0_5_0` as well:
package `secp256k1-sys v0.6.0`
    ... which satisfies dependency `secp256k1-sys = "^0.6.0"` of package `secp256k1 v0.24.0`
    ... which satisfies dependency `secp256k1 = "^0.24.0"` of package `sp-core v6.0.0 (https://github.com/paritytech/substrate?branch=polkadot-v0.9.27#8eff668a)`
    ... which satisfies git dependency `sp-core` of package `beefy-primitives v4.0.0-dev (https://github.com/paritytech/substrate?branch=polkadot-v0.9.27#8eff668a)`
    ... which satisfies git dependency `beefy-primitives` of package `beefy-merkle-tree v4.0.0-dev (https://github.com/paritytech/substrate?branch=polkadot-v0.9.27#8eff668a)`
    ... which satisfies git dependency `beefy-merkle-tree` of package `substrate-test-runtime v2.0.0 (https://github.com/paritytech/substrate?branch=polkadot-v0.9.27#8eff668a)`
    ... which satisfies git dependency `substrate-test-runtime` of package `sc-service-test v2.0.0 (https://github.com/paritytech/substrate?branch=polkadot-v0.9.27#8eff668a)`
    ... which satisfies git dependency `sc-service-test` of package `phala-node v3.0.0 (/Users/jasl/Workspaces/BlockChain/phala-blockchain/standalone/node)`
Only one package in the dependency graph may specify the same links value. This helps ensure that only one copy of a native library is linked in the final binary. Try to adjust your dependencies so that only one package uses the links ='secp256k1-sys' value. For more information, see https://doc.rust-lang.org/cargo/reference/resolver.html#links.

HCastano added a commit that referenced this pull request Aug 9, 2022
* Bump secp256k1 (#1348)

* Bump versions to `v3.3.1`

* Use Docker image from closer to the `v3.3.0` release date

There's been a lot of changes related to the nightly compiler version
and I don't think it's worth pulling them into this release.

* Add release notes for `v3.3.1`

Co-authored-by: Alexander Theißen <alex.theissen@me.com>
@HCastano
Copy link
Contributor

HCastano commented Aug 9, 2022

@jasl we have a new v3.3.1 release out for you

@jasl
Copy link

jasl commented Aug 9, 2022

@jasl we have a new v3.3.1 release out for you

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants