New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract ink_core/memory into its own sub-crate #143
Conversation
Codecov Report
@@ Coverage Diff @@
## master #143 +/- ##
==========================================
- Coverage 86.33% 86.22% -0.12%
==========================================
Files 60 60
Lines 4830 5125 +295
==========================================
+ Hits 4170 4419 +249
- Misses 660 706 +46
Continue to review full report at Codecov.
|
According to our new guidelines every crate requires a README that (shortly) describes what it is about. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing a README
So not just a symlink to the root README like in the other crates? |
That's a good question. |
As an experiment, I'm generating the README with cargo readme. It will use the crate module level docs and the template to generate the README. If we like this idea we can use it for other crates and use a shared template, and perhaps some automation to generate the READMEs. |
@Robbepop does that seem a reasonable solution for the README? |
I really like the direction of separating this functionality out into its own sub-crate, however, I think we can do even better than simply moving the bits over. This could potentially act as a So all What about |
See #157 |
Resolves #110.
For now I've reexported
ink_memory
asmemory
fromink_core
, so all existing imports are valid. Undecided about whether to directly importink_memory
for usages incore
andmodel
.