Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] ext_call PR followup and refinements #171

Merged
merged 3 commits into from Aug 16, 2019
Merged

[core] ext_call PR followup and refinements #171

merged 3 commits into from Aug 16, 2019

Conversation

Robbepop
Copy link
Collaborator

Quick followup PR for #133 .

@codecov-io
Copy link

codecov-io commented Aug 16, 2019 •
edited

Codecov Report

❗ No coverage uploaded for pull request base (master@1228905). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #171   +/-   ##
=========================================
  Coverage          ?   79.21%           
=========================================
  Files             ?       67           
  Lines             ?     5009           
  Branches          ?        0           
=========================================
  Hits              ?     3968           
  Misses            ?     1041           
  Partials          ?        0
Impacted Files Coverage Δ
core/src/env/test_env.rs 37.27% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1228905...ec5edf8. Read the comment docs.

ascjones
ascjones previously approved these changes Aug 16, 2019
View reviewed changes
Copy link
Collaborator

@ascjones ascjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Check out my suggestion in #172 to remove some duplication.

core/src/env/srml/srml_only/impls.rs Outdated Show resolved Hide resolved
ascjones
ascjones previously approved these changes Aug 16, 2019
View reviewed changes
Copy link
Collaborator

@ascjones ascjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Robbepop Robbepop merged commit ecd609d into master Aug 16, 2019
@HCastano HCastano deleted the add-ext-call-followup branch July 29, 2022 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ascjones ascjones ascjones left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Robbepop @codecov-io @ascjones