Provide a StorageVec datastructure
#1995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cyrill Leutwiler <bigcyrill@hotmail.com>
Signed-off-by: Cyrill Leutwiler <bigcyrill@hotmail.com>
Signed-off-by: xermicus <cyrill@parity.io>
Signed-off-by: xermicus <cyrill@parity.io>
Signed-off-by: Cyrill Leutwiler <bigcyrill@hotmail.com>
Signed-off-by: Cyrill Leutwiler <bigcyrill@hotmail.com>
Signed-off-by: xermicus <cyrill@parity.io>
Signed-off-by: xermicus <cyrill@parity.io>
Signed-off-by: xermicus <cyrill@parity.io>
Signed-off-by: xermicus <cyrill@parity.io>
Signed-off-by: Cyrill Leutwiler <bigcyrill@hotmail.com>
Signed-off-by: Cyrill Leutwiler <bigcyrill@hotmail.com>
Signed-off-by: Cyrill Leutwiler <bigcyrill@hotmail.com>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1995 +/- ##
==========================================
+ Coverage 53.37% 53.84% +0.47%
==========================================
Files 220 221 +1
Lines 6884 6957 +73
Branches 0 3068 +3068
==========================================
+ Hits 3674 3746 +72
- Misses 3210 3211 +1 ☔ View full report in Codecov by Sentry. |
🦑 📈 ink! Example Contracts ‒ Changes Report 📉 🦑These are the results when building the
Link to the run | Last update: Thu Nov 30 13:09:55 CET 2023 |
xermicus
requested review from
cmichi,
ascjones and
SkymanOne
as code owners
Signed-off-by: Cyrill Leutwiler <bigcyrill@hotmail.com>
|
I agree with Andrew, and I like this approach more than a Rust-like vector with caching inside. |
Signed-off-by: Cyrill Leutwiler <bigcyrill@hotmail.com>
Signed-off-by: Cyrill Leutwiler <bigcyrill@hotmail.com>
Signed-off-by: Cyrill Leutwiler <bigcyrill@hotmail.com>
|
Yeah why not, 🪓 it |
Signed-off-by: Cyrill Leutwiler <bigcyrill@hotmail.com>
SkymanOne
approved these changes
Nov 29, 2023
crates/storage/src/lazy/vec.rs
Outdated
| pub fn len(&self) -> u32 { | ||
| debug_assert!(self.len_cached.is_none() || self.len.get() == self.len_cached); | ||
|
|
||
| self.len_cached |
There was a problem hiding this comment.
My understanding here is that subsequent calls of len() will still call uncached len? Why not cache it here?
There was a problem hiding this comment.
For that, and all other getters it would need a &mut self receiver.
Maybe could get around that with interior mutability to remove the inefficiency.
There was a problem hiding this comment.
Yeah I missed that. Easy to do with a Cell though
There was a problem hiding this comment.
@SkymanOne added it together with a test
ascjones
reviewed
Nov 29, 2023
crates/ink/tests/ui/contract/fail/constructor-return-result-non-codec-error.stderr
Outdated
Show resolved
Hide resolved
…s for the caching to work Signed-off-by: Cyrill Leutwiler <bigcyrill@hotmail.com>
Signed-off-by: Cyrill Leutwiler <bigcyrill@hotmail.com>
Signed-off-by: Cyrill Leutwiler <bigcyrill@hotmail.com>
Signed-off-by: Cyrill Leutwiler <bigcyrill@hotmail.com>
xgreenx
reviewed
Nov 30, 2023
Co-authored-by: Green Baneling <XgreenX9999@gmail.com>
|
@xgreenx I see, Just merged it to get it into the RC, but can do a follow up for adding a swap remove API anytime :) |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Provide a vector like data structure, built on top of
Mapping.This allows to retrieve elements from the vector and grow the vector without loading and pushing all elements.
Description
Alternative: #1997
I favor this implementation slightly over #1997. It is less code and adds less contract size. The drawback is that here we have no iterators and no
Index. However, I don't think iterators are really required. Also, #1997 provides binary search, however the vector needs to be sorted and this is kind of impossible if it grows too large.Checklist before requesting a review
CHANGELOG.md