Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clippy::upper-case-acronyms #697

Merged
merged 3 commits into from Feb 22, 2021

Conversation

cmichi
Copy link
Collaborator

@cmichi cmichi commented Feb 22, 2021

Currently clippy breaks on master due to

error: name `__ink_Message_0x17FEB370` contains a capitalized acronym
  --> lib.rs:23:1
   |
23 | #[ink::contract]
   | ^^^^^^^^^^^^^^^^
   |
   = note: `-D clippy::upper-case-acronyms` implied by `-D warnings`
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms
   = note: this error originates in an attribute macro (in Nightly builds, run with -Z macro-backtrace for more info)
error: name `__ink_Constructor_0x9BAE9D5E` contains a capitalized acronym
  --> lib.rs:23:1
   |
23 | #[ink::contract]
   | ^^^^^^^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms
   = note: this error originates in an attribute macro (in Nightly builds, run with -Z macro-backtrace for more info)
error: aborting due to 2 previous errors
error: could not compile `contract_terminate`

@cmichi cmichi requested a review from Robbepop February 22, 2021 10:26
Copy link
Collaborator

@Robbepop Robbepop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tbh, I dislike small-letter hex-codes but this apparently is invisible to users generally anyways and causes trouble, so I approve.

@cmichi cmichi merged commit 01f3e7c into master Feb 22, 2021
@cmichi cmichi deleted the cmichi-fix-nightly-clippy-capitalized-hex branch February 22, 2021 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants