[cli] Update new cli for latest flipper
#70
Conversation
Codecov Report
@@ Coverage Diff @@
## master #70 +/- ##
==========================================
- Coverage 84.23% 84.06% -0.17%
==========================================
Files 59 59
Lines 4547 4556 +9
==========================================
Hits 3830 3830
- Misses 717 726 +9
Continue to review full report at Codecov.
|
cli/Cargo.toml
Outdated
| @@ -1,7 +1,7 @@ | |||
| [package] | |||
| name = "cargo-contract" | |||
| version = "0.1.0" | |||
| authors = ["Robin Freyler <robin@parity.io>", "Parity Technologies <admin@parity.io>"] | |||
| authors = ["Parity Technologies <admin@parity.io>"] | |||
There was a problem hiding this comment.
I don't understand this change since I thought that this is already in master, isn't it?
There was a problem hiding this comment.
Yeah so at the "Converation" tab it says that this branch is out of date and you should update it. Please do so. :S
cli/README.md
Outdated
| @@ -0,0 +1,3 @@ | |||
| # Cargo plugin for Ink contracts | |||
|
|
|||
| A small CLI tool for helping setting up and managing WebAssembly smart contracts written with ink!. | |||
| # cargo clean | ||
| # rm Cargo.lock | ||
|
|
||
| CARGO_INCREMENTAL=0 cargo build --release --features generate-api-description --target=wasm32-unknown-unknown --verbose |
There was a problem hiding this comment.
Why have you removed && here?
I think our approach was to add set -e, wasn't it?
There was a problem hiding this comment.
I copied what was in the build.sh script from the examples. Can you suggest an improvement to this?
There was a problem hiding this comment.
Just add set -e on top of the script for now
|
@ascjones Will try to help get this fixed... |
Tested on MacOS