Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement seal_rent_status #798

Merged
merged 5 commits into from
May 27, 2021
Merged

Implement seal_rent_status #798

merged 5 commits into from
May 27, 2021

Conversation

cmichi
Copy link
Collaborator

@cmichi cmichi commented May 27, 2021

Follow-up for paritytech/substrate#8780.

Needed for #539.

@cmichi cmichi requested a review from athei May 27, 2021 02:48
athei
athei suggested changes May 27, 2021
View reviewed changes
Copy link
Contributor

@athei athei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are missing one argument from the function.

athei
athei approved these changes May 27, 2021
View reviewed changes
Copy link
Contributor

@athei athei left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cmichi cmichi force-pushed the cmichi-implement-seal-rent-status branch from 07afb67 to 0e769f7 Compare May 27, 2021 10:30
@cmichi cmichi merged commit 2310400 into master May 27, 2021
@cmichi cmichi deleted the cmichi-implement-seal-rent-status branch May 27, 2021 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Robbepop Robbepop Robbepop left review comments

@athei athei athei approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cmichi @athei @Robbepop