This repository has been archived by the owner on May 24, 2022. It is now read-only.
Add distinctValues #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 99
💛 - Coveralls |
axelchalon
reviewed
Sep 7, 2018
| */ | ||
| export const distinctValues = <T>() => | ||
| distinctUntilChanged<T>((x, y) => { | ||
| if (x instanceof BigNumber && y instanceof BigNumber) { |
There was a problem hiding this comment.
see MikeMcl/bignumber.js#111
related: parity-js/ui#8 (comment)
It would be safer to use BigNumber.isBigNumber(x) && BigNumber.isBigNumber(y) (https://mikemcl.github.io/bignumber.js/#isBigNumber)
There was a problem hiding this comment.
Ah, right! Thanks, I'll change it asap
axelchalon
reviewed
Sep 7, 2018
| import { distinctValues } from './distinctValues'; | ||
|
|
||
| // Observable that fires 2 times | ||
| const fireTwice$ = () => concat(of(0), of(1)); |
There was a problem hiding this comment.
wouldn't this be the same as () => of(0, 1); ?
axelchalon
reviewed
Sep 7, 2018
| .subscribe(() => { | ||
| ++numberOfTimesCalled; | ||
| }); | ||
| setTimeout(() => { |
There was a problem hiding this comment.
I think we could use
.finalize(() => {
expect(numberOfTimesCalled).toEqual(1);
done();
}
axelchalon
reviewed
Sep 7, 2018
| * @param value - A value to test | ||
| */ | ||
| const testValue = (value: any, type: string) => | ||
| it('should only fire once for `type`', done => { |
There was a problem hiding this comment.
maybe
`should only fire once for ${type}`
axelchalon
reviewed
Sep 7, 2018
| testValue({ foo: 'bar' }, 'object'); | ||
| testValue(new BigNumber(2), 'BigNumber'); | ||
|
|
||
| it('should only fire twice for difference values', done => { |
axelchalon
reviewed
Sep 7, 2018
| fireTwice$().subscribe(() => { | ||
| ++numberOfTimesCalled; | ||
| }); | ||
| setTimeout(() => { |
There was a problem hiding this comment.
can also use finalize here I think
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So that RpcObservables don't fire again when the value didn't change.