This repository has been archived by the owner on May 24, 2022. It is now read-only.
feat: add versionInfo$ #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axelchalon
force-pushed
the
ac-versioninfo
branch
from
12bcfbf
to
6f2b5d6
Compare
amaury1093
reviewed
Mar 6, 2019
| @@ -36,7 +36,7 @@ export const switchMapPromise = <T,U>(promise: () => Promise<U>) => ( | |||
| ) | |||
| ); | |||
| console.groupEnd(); | |||
| return empty(); | |||
| return throwError(err) as Observable<U>; | |||
There was a problem hiding this comment.
Could we actually remove the catchError block altogether? Also, the function comment should be modified.
On another note: The reason I initially wanted to return empty() was because of e.g. balanceOf$(), if one of the eth_getBalance calls fails for whatever reason, then the whole Observable errors and stops. In fether, I had some occasions where transactionCount$ failed once or twice because of the light node, but it retried on new head, so the overall behavior was okay. I just don't want transactionCount$ to stop completely if one of the eth_getTransactionCount fails.
amaury1093
approved these changes
Mar 11, 2019
amaury1093
approved these changes
Mar 12, 2019
amaury1093
reviewed
Mar 12, 2019
package.json
Outdated
| @@ -40,5 +40,8 @@ | |||
| "typedoc": "^0.14.2", | |||
| "typedoc-plugin-markdown": "^1.1.13", | |||
| "typescript": "^3.1.6" | |||
| }, | |||
| "dependencies": { | |||
There was a problem hiding this comment.
I believe this shouldn't be here
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some changes required for openethereum/fether#204
options.emitErrors === true. This is needed to check the version of the running instance of Parity (part of Bundle Parity Ethereum in Fether's binary fether#204): if the RPC parity_versionInfo fails, we know that we're running Parity Ethereum <v2.4.1 (in fether-react)parityPathto runParity and signerNewToken, which lets us run those commands on the bundled Parity binary