This repository has been archived by the owner on May 24, 2022. It is now read-only.
Add transactionCountOf$ (eth_getTransactionCount) #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axelchalon
force-pushed
the
ac-transactioncountof
branch
from
c6e0a2e
to
4325999
Compare
axelchalon
force-pushed
the
ac-transactioncountof
branch
from
4325999
to
6a0188c
Compare
amaury1093
reviewed
Dec 18, 2018
| calls: ['eth_getTransactionCount'], | ||
| frequency: [frequency.onEveryBlock$, frequency.onStartup$], | ||
| name: 'transactionCountOf$', | ||
| pipes: api => [switchMapPromise(() => api.eth.getTransactionCount(address).then(Number))] |
There was a problem hiding this comment.
use the Number constructor to convert the value to a number (e.g. "5" to 5)
otherwise the value we receive is an object/string; I thought that it would make sense if transactionCountOf$ returns a number type
There was a problem hiding this comment.
nice. So in this case the TS def should be createRpc$<any, number | Symbol>?
There was a problem hiding this comment.
ah yes, you're right!
axelchalon
force-pushed
the
ac-transactioncountof
branch
from
6a0188c
to
7d42dfa
Compare
amaury1093
approved these changes
Dec 18, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.