Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move unbounded or bounded sends to declaration, rathern than impl locality by default #9

Open
Tracked by #7
drahnr opened this issue Oct 5, 2022 · 0 comments
Open
Tracked by #7

move unbounded or bounded sends to declaration, rathern than impl locality by default #9

drahnr opened this issue Oct 5, 2022 · 0 comments

Comments

@drahnr
Copy link
Collaborator

drahnr commented Oct 5, 2022 •
edited
Loading

Unify the sender API and only provide one API async fn send_message(msg: ..). bounded or unbounded is an impl detail that should be provided at the subsystem declaration, i.e.#[subsystem(DisputeDistributionMessage, sends: [ RuntimeApiMessage, DisputeCoordinatorMessage as unbounded, NetworkBridgeMessage,])] and thesend_messageimpl will take care of using the correct channels.ChannelsOut will also contain less entries.

   #[subsystem(DisputeDistributionMessage, sends: [
              RuntimeApiMessage,
              DisputeCoordinatorMessage as unbounded,
              NetworkBridgeMessage,
])]

and the send_message impl will take care of using the correct channels. ChannelsOut will also contain less entries.
@drahnr drahnr mentioned this issue Oct 5, 2022
Open
3 tasks
@drahnr drahnr changed the title Unify the sender API and only provide one API async fn send_message(msg: ..). bounded or unbounded is an impl detail that should be provided at the subsystem declaration, i.e.#[subsystem(DisputeDistributionMessage, sends: [ RuntimeApiMessage, DisputeCoordinatorMessage as unbounded, NetworkBridgeMessage,])] and the send_message impl will take care of using the correct channels. ChannelsOut will also contain less entries. move unbounded or bounded sends to declaration, rathern than impl locality by default Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@drahnr