Default to default logging sync=info

[5chdn]

Incldues:

• Default to default logging sync=info.
• Introduce --quiet flag to suppress that.
• Improve help messages wording a little bit.
• Updated README.md to reflect the changes.

Rationale:

• It certainly makes sense to default to sync=info logging at some point. (Or to write a beautiful logger.)
• Downside is that any use of RUST_LOG only works in combination with the -q switch to suppress the default logging.

[svyatonik]

Perfect technically, however I'm not sure if it is a good idea to disable RUST_LOG by default, in favor of defaulting sync=info. Afaik, RUST_LOG=trace works in parity along with informer (I can be wrong, but I'm pretty sure I used RUST_LOG to enable secretstore traces). So maybe we could do the same someday. I'll approve, but will leave it for merge to someone else.

[5chdn]

Just tested, sync=info overrides RUST_LOG=trace and the latter only works with -q.

[svyatonik]

I've started parity with cl:

RUST_LOG=secretstore=trace,secretstore_net=trace ./parity --config kovan_ss1.toml

and with config:

[parity]
chain = "kovan"
base_path = "db.kovan_ss1"

[ui]
disable = true

[rpc]
disable = true

[ipc]
disable = true

[dapps]
disable = true

[network]
port = 30303

[secretstore]
disable = false
self_secret = "6c26a76e9b31048d170873a791401c7e799a11f0cefc0171cc31a49800967509"
nodes = ["cac6c205eb06c8308d65156ff6c862c62b000b8ead121a4455a8ddeff7248128d895692136f240d5d1614dc7cc4147b1bd584bd617e30560bb872064d09ea325@127.0.0.1:8085", "6b8d9b9ecde2f0d8c7b2685dd10d181000fa0b26462674dece3096488d6b8d6e3c0e4e1262e3f0eb3b997783b3d6471c281905c5fafeb7908f3aeb7326274db6@127.0.0.1:8087"]
interface = "local"
port = 8083
http_interface = "local"
http_port = 8082
path = "db.kovan_ss1/secretstore"

[ipfs]
enable = false

[snapshots]
disable_periodic = true

So there's no -q in cl. But I still can see secretstore' TRACE-level messages in output:

2017-08-30 09:35:46  IO Worker #3 INFO import  Syncing snapshot 12/31        #0    4/25 peers   8 KiB chain 7 KiB db 0 bytes queue 10 KiB sync  RPC:  0 conn,  0 req/s,   0 µs
2017-08-30 09:35:51  IO Worker #3 INFO import  Syncing snapshot 19/31        #0    4/25 peers   8 KiB chain 7 KiB db 0 bytes queue 10 KiB sync  RPC:  0 conn,  0 req/s,   0 µs
2017-08-30 09:35:56   TRACE secretstore_net  d013…1923: executing maintain procedures
2017-08-30 09:35:56   WARN secretstore_net  d013…1923: network error Connection refused (os error 111) when establishing outbound connection with 127.0.0.1:8085
2017-08-30 09:35:56   WARN secretstore_net  d013…1923: network error Connection refused (os error 111) when establishing outbound connection with 127.0.0.1:8087
2017-08-30 09:35:56  IO Worker #1 INFO import  Syncing snapshot 26/31        #0    4/25 peers   8 KiB chain 7 KiB db 0 bytes queue 10 KiB sync  RPC:  0 conn,  0 req/s,   0 µs

I maybe missing something, but looks like it works even without '-q' flag

[5chdn]

I'm talking about pbtc -q, sorry :)

but introducing an -l flag like parity has, would be nice, too.

[svyatonik]

@5chdn Hope you don't mind that I've added this change to your PR: now RUST_LOG works even without '-q' flag. So now pbtc behaves the same way as parity does

[5chdn]

Just noticed. Compiling.

[5chdn]

Switching to WIP. Will test it when I'm back at some place with real internet.

[5chdn]

@5chdn Hope you don't mind that I've added this change to your PR: now RUST_LOG works even without '-q' flag. So now pbtc behaves the same way as parity does

Yes, works for me. I updated the README, this is good to go now.

[svyatonik]

Cool, thanks :)

[5chdn]

Just to understand this, where does env_filters come from in this context?

[svyatonik]

from environment variable RUST_LOG . and in format!() I just merge these two together, so that it would be either (RUST_LOG and sync=info) or (RUST_LOG), depending on -q existance => RUST_LOG always works

[5chdn]

Super elegant. Thanks.