Fix compilation on Windows

[ordian]

Thanks to paritytech/jsonrpc/pull/311 it should fix compilation on windows.

[ordian]

looks like it doesn't: https://gitlab.parity.io/parity/parity-ethereum/-/jobs/98622

[5chdn]

looks good, but doesn't seem to fix windows.

error[E0308]: mismatched types
  --> cargo\git\checkouts\parity-tokio-ipc-05ab97e34cab4146\c0f80b4\src\lib.rs:92:27
   |
92 |         NamedPipe::new(p, handle)
   |                           ^^^^^^ expected struct `tokio_reactor::Handle`, found struct `tokio_core::reactor::Handle`
   |
   = note: expected type `&tokio_reactor::Handle`
              found type `&tokio_core::reactor::Handle`

error[E0308]: mismatched types
   --> cargo\git\checkouts\parity-tokio-ipc-05ab97e34cab4146\c0f80b4\src\lib.rs:149:36
    |
149 |     NamedPipe::from_pipe(mio_pipe, handle)
    |                                    ^^^^^^ expected struct `tokio_reactor::Handle`, found struct `tokio_core::reactor::Handle`
    |
    = note: expected type `&tokio_reactor::Handle`
               found type `&tokio_core::reactor::Handle`

error[E0061]: this function takes 1 parameter but 0 parameters were supplied
   --> cargo\git\checkouts\parity-tokio-ipc-05ab97e34cab4146\c0f80b4\src\lib.rs:186:37
    |
186 |                     self.inner.pipe.poll_write();
    |                                     ^^^^^^^^^^ expected 1 parameter

error[E0308]: mismatched types
   --> cargo\git\checkouts\parity-tokio-ipc-05ab97e34cab4146\c0f80b4\src\lib.rs:233:51
    |
233 |         let pipe = NamedPipe::from_pipe(mio_pipe, &handle)?;
    |                                                   ^^^^^^^ expected struct `tokio_reactor::Handle`, found reference
    |
    = note: expected type `&tokio_reactor::Handle`
               found type `&&tokio_core::reactor::Handle`

error[E0061]: this function takes 1 parameter but 0 parameters were supplied
   --> cargo\git\checkouts\parity-tokio-ipc-05ab97e34cab4146\c0f80b4\src\lib.rs:256:20
    |
256 |         self.inner.poll_read()
    |                    ^^^^^^^^^ expected 1 parameter

error[E0308]: mismatched types
   --> cargo\git\checkouts\parity-tokio-ipc-05ab97e34cab4146\c0f80b4\src\lib.rs:256:9
    |
255 |     fn poll_read(&mut self) -> Async<()> {
    |                                --------- expected `futures::Async<()>` because of return type
256 |         self.inner.poll_read()
    |         ^^^^^^^^^^^^^^^^^^^^^^ expected enum `futures::Async`, found enum `std::result::Result`
    |
    = note: expected type `futures::Async<()>`
               found type `std::result::Result<futures::Async<usize>, std::io::Error>`

error[E0061]: this function takes 1 parameter but 0 parameters were supplied
   --> cargo\git\checkouts\parity-tokio-ipc-05ab97e34cab4146\c0f80b4\src\lib.rs:260:20
    |
260 |         self.inner.poll_write()
    |                    ^^^^^^^^^^ expected 1 parameter

error[E0308]: mismatched types
   --> cargo\git\checkouts\parity-tokio-ipc-05ab97e34cab4146\c0f80b4\src\lib.rs:260:9
    |
259 |     fn poll_write(&mut self) -> Async<()> {
    |                                 --------- expected `futures::Async<()>` because of return type
260 |         self.inner.poll_write()
    |         ^^^^^^^^^^^^^^^^^^^^^^^ expected enum `futures::Async`, found enum `std::result::Result`
    |
    = note: expected type `futures::Async<()>`
               found type `std::result::Result<futures::Async<usize>, std::io::Error>`

error: aborting due to 8 previous errors

[ordian]

parity-tokio-ipc@c0f80b4039 depends on master branch of tokio-named-pipes

[ordian]

It seems to compile on windows (at least parity-tokio-ipc), but note, that this solution is not sustainable, e.g. the build will break after next cargo update -p jsonrpc-core. The proper long-term solution is to migrate jsonrpc-core to the new API from parity-tokio-ipc.

[5chdn]

please merge master to update pipelines.

[ordian]

Not sure which test has failed: https://gitlab.parity.io/parity/parity-ethereum/-/jobs/99009 :/

updated