Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

[ethcore] remove error_chain #10616

Merged
merged 8 commits into from
May 6, 2019
Merged

[ethcore] remove error_chain #10616

merged 8 commits into from
May 6, 2019

Conversation

ascjones
Copy link
Contributor

@ascjones ascjones commented Apr 29, 2019 •
edited

rel: #10302

Replaces error_chain with manual Error impl and derived Display.

@ascjones ascjones marked this pull request as ready for review April 30, 2019 08:13
@ascjones ascjones added A0-pleasereview 🤓 Pull request needs code review. M4-core ⛓ Core client code / Rust. labels Apr 30, 2019
@ascjones ascjones requested review from HCastano and removed request for HCastano April 30, 2019 08:29
HCastano
HCastano approved these changes Apr 30, 2019
View reviewed changes
Copy link
Contributor

@HCastano HCastano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a lot of tedious work, thanks for doing this!

@jam10o-new jam10o-new mentioned this pull request Apr 30, 2019
Closed
4 tasks
@ascjones ascjones added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Apr 30, 2019
@ordian ordian merged commit 98b89c8 into master May 6, 2019
@ordian ordian deleted the aj-ethcore-error branch May 6, 2019 13:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ordian ordian ordian approved these changes

@HCastano HCastano HCastano approved these changes

@niklasad1 niklasad1 niklasad1 approved these changes

Assignees
No one assigned
Labels
A8-looksgood 🦄 Pull request is reviewed well. M4-core ⛓ Core client code / Rust.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ascjones @ordian @HCastano @niklasad1