Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Upgrade to parity-crypto 0.4 #10650

Merged
merged 8 commits into from
May 28, 2019
Merged

Upgrade to parity-crypto 0.4 #10650

merged 8 commits into from
May 28, 2019

Conversation

dvdplm
Copy link
Collaborator

@dvdplm dvdplm commented May 13, 2019 •
edited

Reverts using NonZeroU32 (introduced here).

Ref. paritytech/parity-common#149

@dvdplm
[whisper] Move needed aes_gcm crypto in-crate
cb6ab20 
In the latest `parity-crypto` release (upcoming 0.4), the aes GCM features were removed (done to remove the dependency on `ring`).
This PR adds the bare minimum crypto needed for Whisper directly to the crate itself and as those were the only features needed from `parity-crypto`, removes the dependency on that crate altogether.
@dvdplm
Upgrade to parity-crypto 0.4
14a24ab 
Reverts using NonZeroU32 (introduced [here](b347599)).
@dvdplm dvdplm requested a review from ordian May 13, 2019 10:26
@dvdplm dvdplm self-assigned this May 13, 2019
@dvdplm dvdplm added the A0-pleasereview 🤓 Pull request needs code review. label May 13, 2019
@dvdplm
Check for 0 in args.arg_keys_iteration
51f51f6
@dvdplm
Merge branch 'master' into dp/chore/switch-to-new-parity-crypto
c7808ac 
* master:
  docs: Add ProgPoW Rust docs to ethash module (#10653)
  fix: Move PR template into .github/ folder (#10663)
  docs: Add PR template (#10654)
  Trivial journal for private transactions (#10056)
  fix(compilation warnings) (#10649)
  [whisper] Move needed aes_gcm crypto in-crate (#10647)
@dvdplm
Use beta.4
b7235cb
@dvdplm
Merge branch 'master' into dp/chore/switch-to-new-parity-crypto
02eff51 
* master:
  Remove support for hardware wallets (#10678)
  [CI] allow cargo audit to fail (#10676)
ordian
ordian approved these changes May 22, 2019
View reviewed changes
Copy link
Collaborator

@ordian ordian left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm modulo publishing parity-crypto 0.4.0 and replacing 0.4.0-beta.4 with 0.4.0

@ordian ordian added A8-looksgood 🦄 Pull request is reviewed well. M5-dependencies 🖇 Dependencies. and removed A0-pleasereview 🤓 Pull request needs code review. labels May 22, 2019
@ordian ordian added this to the 2.6 milestone May 22, 2019
@dvdplm
Merge branch 'master' into dp/chore/switch-to-new-parity-crypto
3d62cb0 
* master:
  Don't panic if extra_data is longer than VANITY_LENGTH (#10682)
  docs: evmbin - Update Rust docs (#10658)
  Remove annoying compiler warnings (#10679)
  Reset blockchain properly (#10669)
@ordian ordian added the M4-core ⛓ Core client code / Rust. label May 22, 2019
@sorpaas sorpaas merged commit 9584fae into master May 28, 2019
@sorpaas sorpaas deleted the dp/chore/switch-to-new-parity-crypto branch May 28, 2019 05:50
ordian added a commit that referenced this pull request May 28, 2019
@ordian
Merge branch 'master' into ao-upgrade-ethereum-types
4f398f4 
* master:
  Upgrade to parity-crypto 0.4 (#10650)
  new image (#10673)
  Add SealingState; don't prepare block when not ready. (#10529)
  Fix compiler warning (that will become an error) (#10683)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ordian ordian ordian approved these changes

@sorpaas sorpaas sorpaas approved these changes

Assignees

@dvdplm dvdplm

Labels
A8-looksgood 🦄 Pull request is reviewed well. M4-core ⛓ Core client code / Rust. M5-dependencies 🖇 Dependencies.
Projects
None yet
Milestone
2.6
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dvdplm @ordian @sorpaas