Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

introduce MissingParent Error, fixes #10699 #10700

Merged
merged 1 commit into from May 31, 2019
Merged

introduce MissingParent Error, fixes #10699 #10700

merged 1 commit into from May 31, 2019

Conversation

ghost
Copy link

@ghost ghost commented May 29, 2019

draft, provided based on code/code-doc review.

fixes #10699

@parity-cla-bot
Copy link

It looks like @lazaridiscom signed our Contributor License Agreement. 👍

Many thanks,

Parity Technologies CLA Bot

dvdplm
dvdplm approved these changes May 29, 2019
View reviewed changes
Copy link
Collaborator

@dvdplm dvdplm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm to me

ethcore/src/engines/mod.rs Show resolved Hide resolved
@dvdplm dvdplm requested a review from ngotchac May 30, 2019 07:18
ngotchac
ngotchac approved these changes May 31, 2019
View reviewed changes
Copy link
Contributor

@ngotchac ngotchac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would also like to have info on the missing parent's hash in the error log, and AFAIK it wouldn't be that much of a trouble to add it. Otherwise, LGTM

@dvdplm dvdplm merged commit 33d3bfa into openethereum:master May 31, 2019
ordian added a commit that referenced this pull request Jun 3, 2019
@ordian
Merge branch 'master' into ao-upgrade-ethereum-types
94db3a0 
* master:
  introduce MissingParent Error, fixes #10699 (#10700)
  Update publishing (#10644)
@MarkusTeufelberger MarkusTeufelberger mentioned this pull request Jun 11, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provide Dedicated Error re #10085
4 participants
@parity-cla-bot @dvdplm @ngotchac @lazaridiscom