This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Print warnings when using dangerous settings for ValidatorSet #10733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Escalate bad proposer to warning
…when-validators-is-1-or-even * dp/hc-non-canon-block-logging: More readable code
…when-validators-is-1-or-even * dp/hc-non-canon-block-logging: Wording Extensive logging on unexpected non-canonical hash
Co-Authored-By: Tomasz Drwięga <tomusdrw@users.noreply.github.com>
…hub.com:paritytech/parity-ethereum into dp/chore/aura-warn-when-validators-is-1-or-even * 'dp/chore/aura-warn-when-validators-is-1-or-even' of github.com:paritytech/parity-ethereum: Update ethcore/blockchain/src/blockchain.rs
ltfschoen
reviewed
Jun 11, 2019
Co-Authored-By: Luke Schoen <ltfschoen@users.noreply.github.com>
tomusdrw
approved these changes
Jun 14, 2019
tomusdrw
reviewed
Jun 14, 2019
…-even * master: [devp2p] Update to 2018 edition (#10716) Add a way to signal shutdown to snapshotting threads (#10744) Enable aesni (#10756) remove support of old SS db formats (#10757) [devp2p] Don't use `rust-crypto` (#10714) updater: fix static id hashes initialization (#10755) Use fewer threads for snapshotting (#10752) Die error_chain, die (#10747) Fix deprectation warnings on nightly (#10746) fix docker tags for publishing (#10741) DevP2p: Get node IP address and udp port from Socket, if not included in PING packet (#10705) ethcore: enable ECIP-1054 for classic (#10731)
ordian
approved these changes
Jun 21, 2019
ordian
added
A8-looksgood 🦄
dvdplm
added a commit
that referenced
this pull request
Jun 24, 2019
…anager * master: Print warnings when using dangerous settings for ValidatorSet (#10733) ethcore/res: activate atlantis classic hf on block 8772000 (#10766) refactor: Fix indentation (#10740) Updated Bn128PairingImpl to use optimized batch pairing (#10765) fix: aura don't add `SystemTime::now()` (#10720) Initialize private tx logger only if private tx functionality is enabled (#10758) Remove unused code (#10762) Remove calls to heapsize (#10432)
dvdplm
added a commit
that referenced
this pull request
Jun 25, 2019
…dp/fix/prevent-building-block-on-top-of-same-parent * dp/chore/aura-log-validator-set-in-epoch-manager: remove dead code Treat empty account the same as non-exist accounts in EIP-1052 (#10775) docs: Update Readme with TOC, Contributor Guideline. Update Cargo package descriptions (#10652) cleanup On second thought non-validators are allowed to report Move Engine::register_client to be before other I/O handler registration (#10767) cleanup Print warnings when using dangerous settings for ValidatorSet (#10733) ethcore/res: activate atlantis classic hf on block 8772000 (#10766) refactor: Fix indentation (#10740) Updated Bn128PairingImpl to use optimized batch pairing (#10765) fix: aura don't add `SystemTime::now()` (#10720) Initialize private tx logger only if private tx functionality is enabled (#10758) Remove unused code (#10762) Remove calls to heapsize (#10432)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AuRa should not be used with a single validator or with an even number. Print appropriate warnings.
ref. #10085