This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Improve logging and cleanup in miner around block sealing #10745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Escalate bad proposer to warning
…when-validators-is-1-or-even * dp/hc-non-canon-block-logging: More readable code
…when-validators-is-1-or-even * dp/hc-non-canon-block-logging: Wording Extensive logging on unexpected non-canonical hash
Co-Authored-By: Tomasz Drwięga <tomusdrw@users.noreply.github.com>
…hub.com:paritytech/parity-ethereum into dp/chore/aura-warn-when-validators-is-1-or-even * 'dp/chore/aura-warn-when-validators-is-1-or-even' of github.com:paritytech/parity-ethereum: Update ethcore/blockchain/src/blockchain.rs
…p/chore/aura-log-validator-set-in-epoch-manager * dp/chore/aura-warn-when-validators-is-1-or-even: Improved logging, address grumbles Update ethcore/blockchain/src/blockchain.rs
Co-Authored-By: Luke Schoen <ltfschoen@users.noreply.github.com>
…thub.com:paritytech/parity-ethereum into dp/chore/aura-log-validator-set-in-epoch-manager * 'dp/chore/aura-log-validator-set-in-epoch-manager' of github.com:paritytech/parity-ethereum: Update ethcore/src/engines/validator_set/simple_list.rs
Don't require node to be part of the validator set to report malicious behaviour
Co-Authored-By: Luke Schoen <ltfschoen@users.noreply.github.com>
Move check for parent_step == step for clarity&efficiency Remove dead code for Seal::Proposal
…dp/fix/prevent-building-block-on-top-of-same-parent * dp/chore/aura-log-validator-set-in-epoch-manager: remove dead code Treat empty account the same as non-exist accounts in EIP-1052 (#10775) docs: Update Readme with TOC, Contributor Guideline. Update Cargo package descriptions (#10652) cleanup On second thought non-validators are allowed to report Move Engine::register_client to be before other I/O handler registration (#10767) cleanup Print warnings when using dangerous settings for ValidatorSet (#10733) ethcore/res: activate atlantis classic hf on block 8772000 (#10766) refactor: Fix indentation (#10740) Updated Bn128PairingImpl to use optimized batch pairing (#10765) fix: aura don't add `SystemTime::now()` (#10720) Initialize private tx logger only if private tx functionality is enabled (#10758) Remove unused code (#10762) Remove calls to heapsize (#10432)
…me-parent * master: Log validator set changes in EpochManager (#10734)
…me-parent * master: (24 commits) cargo update -p smallvec (#10822) replace memzero with zeroize crate (#10816) Don't repeat the logic from Default impl (#10813) removed additional_params method (#10818) Add Constantinople eips to the dev (instant_seal) config (#10809) removed redundant fmt::Display implementations (#10806) revert changes to .gitlab-ci.yml (#10807) Add filtering capability to `parity_pendingTransactions` (issue 8269) (#10506) removed EthEngine alias (#10805) wait a bit longer in should_check_status_of_request_when_its_resolved (#10808) Do not drop the peer with None difficulty (#10772) ethcore-bloom-journal updated to 2018 (#10804) ethcore-light uses bincode 1.1 (#10798) Fix a few typos and unused warnings. (#10803) updated project to ansi_term 0.11 (#10799) added new ropsten-bootnode and removed old one (#10794) updated price-info to edition 2018 (#10801) ethcore-network-devp2p uses igd 0.9 (#10797) updated parity-local-store to edition 2018 and removed redundant Error type (#10800) Cleanup unused vm dependencies (#10787) ...
…me-parent * master: refactor: whisper: Add type aliases and update rustdocs in message.rs (#10812) Break circular dependency between Client and Engine (part 1) (#10833) tests: Relates to #10655: Test instructions for Readme (#10835) refactor: Related #9459 - evmbin: replace untyped json! macro with fully typed serde serialization using Rust structs (#10657) idiomatic changes to PodState (#10834) Allow --nat extip:your.host.here.org (#10830) When updating the client or when called from RPC, sleep should mean sleep (#10814) Remove excessive warning (#10831) Fix typo in README.md (#10828) ethcore does not use byteorder (#10829) Better logging when backfilling ancient blocks fail (#10796) depends: Update wordlist to v1.3 (#10823)
dvdplm
changed the title
dvdplm
added
A0-pleasereview 🤓
jam10o-new
approved these changes
Jul 4, 2019
ordian
approved these changes
Jul 4, 2019
ordian
added
A8-looksgood 🦄
dvdplm
added a commit
that referenced
this pull request
Jul 4, 2019
* master: Improve logging and cleanup in miner around block sealing (#10745)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #10734
Adds extensive logging around block sealing and does minor cleanup in the miner.