This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Initialize private tx logger only if private tx functionality is enabled #10758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grbIzl
added
A0-pleasereview 🤓
ordian
approved these changes
Jun 18, 2019
|
test failure seems legit |
It was introduced in #10056 As far as I can seee, it was not released yet |
dvdplm
approved these changes
Jun 18, 2019
parity/configuration.rs
Outdated
| @@ -1458,7 +1461,7 @@ mod tests { | |||
| private_provider_conf: ProviderConfig { | |||
| validator_accounts: Default::default(), | |||
| signer_account: Default::default(), | |||
| logs_path: Some(Directories::default().base), | |||
| logs_path: None, | |||
There was a problem hiding this comment.
Seems like ProviderConfig should impl Default too?
dvdplm
added
A7-looksgoodtestsfail 🤖
grbIzl
added
A8-looksgood 🦄
dvdplm
added a commit
that referenced
this pull request
Jun 24, 2019
…anager * master: Print warnings when using dangerous settings for ValidatorSet (#10733) ethcore/res: activate atlantis classic hf on block 8772000 (#10766) refactor: Fix indentation (#10740) Updated Bn128PairingImpl to use optimized batch pairing (#10765) fix: aura don't add `SystemTime::now()` (#10720) Initialize private tx logger only if private tx functionality is enabled (#10758) Remove unused code (#10762) Remove calls to heapsize (#10432)
dvdplm
added a commit
that referenced
this pull request
Jun 25, 2019
…dp/fix/prevent-building-block-on-top-of-same-parent * dp/chore/aura-log-validator-set-in-epoch-manager: remove dead code Treat empty account the same as non-exist accounts in EIP-1052 (#10775) docs: Update Readme with TOC, Contributor Guideline. Update Cargo package descriptions (#10652) cleanup On second thought non-validators are allowed to report Move Engine::register_client to be before other I/O handler registration (#10767) cleanup Print warnings when using dangerous settings for ValidatorSet (#10733) ethcore/res: activate atlantis classic hf on block 8772000 (#10766) refactor: Fix indentation (#10740) Updated Bn128PairingImpl to use optimized batch pairing (#10765) fix: aura don't add `SystemTime::now()` (#10720) Initialize private tx logger only if private tx functionality is enabled (#10758) Remove unused code (#10762) Remove calls to heapsize (#10432)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Private tx logger tried to open log file even for the case, when private tx functionality was disabled.
Closes #10726