Updated Bn128PairingImpl to use optimized batch pairing #10765
Conversation
|
It looks like @seunlanlege signed our Contributor License Agreement. 👍 Many thanks, Parity Technologies CLA Bot |
|
What's different from the original PR? Also I think we have benchmarks for this, can we run them before and after the change to check the improvement? |
|
@andresilva this PR has been rebased with the master branch, benchmarks for this branch |
|
The diff on this PR and #10624 is the same. Also do I understand correctly that all bn128 benchmarks actually got slower with this change? |
from the original author. |
|
@andresilva yes, it’s the same PR but as the original author was busy we’re taking over. Mainly to double check the perf improvement claim. |
|
I've got the following results: https://gist.github.com/ordian/eeb56b65c44580aa59f60013bea2322b |
|
@ordian Thanks for re-running the benchmarks. 👍 |
…anager * master: Print warnings when using dangerous settings for ValidatorSet (#10733) ethcore/res: activate atlantis classic hf on block 8772000 (#10766) refactor: Fix indentation (#10740) Updated Bn128PairingImpl to use optimized batch pairing (#10765) fix: aura don't add `SystemTime::now()` (#10720) Initialize private tx logger only if private tx functionality is enabled (#10758) Remove unused code (#10762) Remove calls to heapsize (#10432)
…dp/fix/prevent-building-block-on-top-of-same-parent * dp/chore/aura-log-validator-set-in-epoch-manager: remove dead code Treat empty account the same as non-exist accounts in EIP-1052 (#10775) docs: Update Readme with TOC, Contributor Guideline. Update Cargo package descriptions (#10652) cleanup On second thought non-validators are allowed to report Move Engine::register_client to be before other I/O handler registration (#10767) cleanup Print warnings when using dangerous settings for ValidatorSet (#10733) ethcore/res: activate atlantis classic hf on block 8772000 (#10766) refactor: Fix indentation (#10740) Updated Bn128PairingImpl to use optimized batch pairing (#10765) fix: aura don't add `SystemTime::now()` (#10720) Initialize private tx logger only if private tx functionality is enabled (#10758) Remove unused code (#10762) Remove calls to heapsize (#10432)
original PR #10624