Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Fix checksums and auto-update push #7846

Merged
merged 12 commits into from Feb 13, 2018
Merged

Fix checksums and auto-update push #7846

merged 12 commits into from Feb 13, 2018

Conversation

tomusdrw
Copy link
Collaborator

@tomusdrw tomusdrw commented Feb 9, 2018

Should go after paritytech/push-release#9 is deployed.

  • Common way to compute md5/sha256/sha3 sums
  • Safe curl wrapper, which fails the build on non-2xx exit codes.
  • Use more specific BUILD_PLATFORM instead of generic PLATFORM when pushing build to updater.

@tomusdrw tomusdrw added A0-pleasereview 🤓 Pull request needs code review. A1-onice 🌨 Pull request is reviewed well, but should not yet be merged. M0-build 🏗 Building and build system. B0-patch labels Feb 9, 2018
@General-Beck
Copy link
Contributor

it is necessary to check in nightly

@5chdn
Copy link
Contributor

5chdn commented Feb 9, 2018

Thanks so much, this was actually on my agenda. Best way to test this is merge and bump nightly, so I agree with @General-Beck here.

@tomusdrw
Copy link
Collaborator Author

tomusdrw commented Feb 9, 2018

Yup, sure. Just wait for the new updater to be deployed.

@5chdn
Copy link
Contributor

5chdn commented Feb 9, 2018

Or actually, let me tag this PR once it's deployed. Any ETA?

@tomusdrw
Copy link
Collaborator Author

tomusdrw commented Feb 9, 2018

@5chdn only nightly or ^v\d+.\d+.\d$ tags will now be accepted by the updater. So I think we should do both (or rather all 3):

  1. Tag master (should go fine, but should be rejected by the updater)
  2. Push to nightly - this should push a new release on kovan.
  3. By tagging before the updater is released we can also test a path where the build fails, because updater crashes.

@tomusdrw tomusdrw removed the A1-onice 🌨 Pull request is reviewed well, but should not yet be merged. label Feb 12, 2018
@5chdn
Copy link
Contributor

5chdn commented Feb 12, 2018

cc @fevo1971

@5chdn 5chdn added the P2-asap 🌊 No need to stop dead in your tracks, however issue should be addressed as soon as possible. label Feb 12, 2018
@5chdn
Copy link
Contributor

5chdn commented Feb 12, 2018

This fail is probably related: https://gitlab.parity.io/parity/parity/-/jobs/78627

push release
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100   228  100    76  100   152   1374   2748 --:--:-- --:--:-- --:--:--  2763
child "sha3" fails because ["sha3" must only contain hexadecimal characters]\n
Unable to push info to updater service.
ERROR: Job failed: exit code 1

@5chdn
Copy link
Contributor

5chdn commented Feb 12, 2018

This probably too: https://gitlab.parity.io/parity/parity/-/jobs/78631

Checksum calculation:
Parity file SHA3: 39746347b20456e15081b540a06188eb41985a1cb56764350a52e53e7ba4db8d
{:timestamp=>"2018-02-12T20:57:29.827336+0000", :message=>"File already exists, refusing to continue: parity-1.10.0-1.x86_64.rpm", :level=>:fatal}
ERROR: Job failed: exit code 1

@5chdn 5chdn added A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. and removed A0-pleasereview 🤓 Pull request needs code review. labels Feb 13, 2018
@5chdn 5chdn added the A8-looksgood 🦄 Pull request is reviewed well. label Feb 13, 2018
@5chdn 5chdn removed the A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. label Feb 13, 2018
@5chdn 5chdn merged commit 5584739 into master Feb 13, 2018
@5chdn 5chdn deleted the td-build-fix branch February 13, 2018 18:31
@5chdn 5chdn added this to the 1.10 milestone Feb 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well. M0-build 🏗 Building and build system. P2-asap 🌊 No need to stop dead in your tracks, however issue should be addressed as soon as possible.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants