This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Remove windows tray and installer #8778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ascjones
added
the
A3-inprogress ⏳
|
It looks like @ascjones signed our Contributor License Agreement. 👍 Many thanks, Parity Technologies CLA Bot |
ascjones
commented
Jun 4, 2018
.gitlab-ci.yml
Outdated
| @@ -173,7 +173,7 @@ windows: | |||
| - stable | |||
| - triggers | |||
| script: | |||
| - sh scripts/gitlab-build.sh x86_64-pc-windows-msvc x86_64-pc-windows-msvc installer "" "" windows | |||
| - sh scripts/gitlab-build.sh x86_64-pc-windows-msvc x86_64-pc-windows-msvc "" "" "" windows | |||
There was a problem hiding this comment.
Not sure what (if anything) should be for the $ARC param instead of installer
There was a problem hiding this comment.
$ARC is just a string that goes into the binary name. I'm pretty sure it's unused after this PR, however, for consistency reasons, could you change it to amd64?
ascjones
commented
Jun 4, 2018
| ./sign.cmd $keyfile $certpass "parity_"$VER"_"$IDENT"_"$ARC"."$EXT | ||
| $MD5_BIN "parity_"$VER"_"$IDENT"_"$ARC"."$EXT -p %h > "parity_"$VER"_"$IDENT"_"$ARC"."$EXT".md5" | ||
| $SHA256_BIN "parity_"$VER"_"$IDENT"_"$ARC"."$EXT -p %h > "parity_"$VER"_"$IDENT"_"$ARC"."$EXT".sha256" | ||
| } |
There was a problem hiding this comment.
AFAICT this is just installer/tray stuff so can be removed entirely.
|
@5chdn @General-Beck am I on the right track here? |
5chdn
added
M2-installer 📲
5 tasks
5chdn
approved these changes
Jun 4, 2018
5chdn
added
the
A4-awaitingci 🤖
|
Uhm, the fails seem to be unrelated? |
|
Hm not sure why, no rust stuff modified or anything before the build step |
|
OK |
|
|
Test fails now:
Works when running locally... @5chdn can you trigger this again? |
|
Yeah, hold on. https://gitlab.parity.io/parity/parity/-/jobs/89357 |
5chdn
added
A8-looksgood 🦄
|
Looks good! |
5chdn
added
the
P2-asap 🌊
debris
approved these changes
Jun 6, 2018
ordian
added a commit
to ordian/parity
that referenced
this pull request
Jun 6, 2018
…rp_sync_on_light_client * 'master' of https://github.com/paritytech/parity: Remove UI related settings from CLI (openethereum#8783) Remove windows tray and installer (openethereum#8778) docs: add changelogs for 1.10.6 and 1.11.3 (openethereum#8810) Fix ancient blocks queue deadlock (openethereum#8751) Disallow unsigned transactions in case EIP-86 is disabled (openethereum#8802) Fix evmbin compilation (openethereum#8795) Have space between feature cfg flag (openethereum#8791) rpc: fix address formatting in TransactionRequest Display (openethereum#8786)
dvdplm
added a commit
that referenced
this pull request
Jun 7, 2018
…eric * origin/master: ethcore: fix ancient block error msg handling (#8832) CI: Fix docker tags (#8822) parity: fix indentation in sync logging (#8794) Removed obsolete IpcMode enum (#8819) Remove UI related settings from CLI (#8783) Remove windows tray and installer (#8778) docs: add changelogs for 1.10.6 and 1.11.3 (#8810) Fix ancient blocks queue deadlock (#8751) Disallow unsigned transactions in case EIP-86 is disabled (#8802) Fix evmbin compilation (#8795) Have space between feature cfg flag (#8791) rpc: fix address formatting in TransactionRequest Display (#8786) Conditionally compile ethcore public test helpers (#8743) Remove Result wrapper from AccountProvider in RPC impls (#8763) Update `license header` and `scripts` (#8666)
5 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #8649. Maybe more to remove, creating this PR for now to test the gitlab CI build.