Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Remove mac os installers etc #8875

Merged
merged 1 commit into from Jun 13, 2018
Merged

Remove mac os installers etc #8875

merged 1 commit into from Jun 13, 2018

Conversation

ascjones
Copy link
Contributor

Part of #8649. Reviewers please confirm I have removed all the correct artifacts.

@5chdn can you set up a test release to make sure the pipelines still work?

@ascjones ascjones added A0-pleasereview 🤓 Pull request needs code review. M2-installer 📲 Installers for MacOS and Windows. labels Jun 12, 2018
@parity-cla-bot
Copy link

It looks like @ascjones signed our Contributor License Agreement. 👍

Many thanks,

Parity Technologies CLA Bot

@debris debris added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Jun 12, 2018
@5chdn
Copy link
Contributor

5chdn commented Jun 12, 2018

* [new tag]             v1.12.0-ci4 -> v1.12.0-ci4

https://gitlab.parity.io/parity/parity/pipelines/20746

@@ -291,11 +275,9 @@ case $BUILD_PLATFORM in
x86_64-apple-darwin)
STRIP_BIN="strip"
PLATFORM="x86_64-apple-darwin"
EXT="pkg"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering where this environment variable is used.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@5chdn looks like it was used to build up a filename here and afaict that's the only place.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep looks like it. Perhaps we can remove EXT for the other platforms?

Copy link
Collaborator

@dvdplm dvdplm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tricky to review for stale code, but this looks fine. Seems low-risk too.

@@ -291,11 +275,9 @@ case $BUILD_PLATFORM in
x86_64-apple-darwin)
STRIP_BIN="strip"
PLATFORM="x86_64-apple-darwin"
EXT="pkg"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@5chdn looks like it was used to build up a filename here and afaict that's the only place.

@5chdn
Copy link
Contributor

5chdn commented Jun 13, 2018

❯ aws s3 ls s3://builds-parity/v1.12.0-ci4/x86_64-apple-darwin/
2018-06-12 20:16:18    2034532 ethkey
2018-06-12 20:16:23         76 ethkey.md5
2018-06-12 20:16:25        108 ethkey.sha256
2018-06-12 20:16:08    2018260 ethstore
2018-06-12 20:16:12         78 ethstore.md5
2018-06-12 20:16:16        110 ethstore.sha256
2018-06-12 20:15:43   33027096 parity
2018-06-12 20:15:57    6960744 parity-evm
2018-06-12 20:16:03         80 parity-evm.md5
2018-06-12 20:16:06        112 parity-evm.sha256
2018-06-12 20:15:53         76 parity.md5
2018-06-12 20:15:55        108 parity.sha256
2018-06-12 20:16:28    3844860 whisper
2018-06-12 20:16:33         77 whisper.md5
2018-06-12 20:16:35        109 whisper.sha256

@5chdn 5chdn merged commit 95a601d into master Jun 13, 2018
@5chdn 5chdn deleted the aj-remove-macos-installers-etc branch June 13, 2018 07:15
@5chdn 5chdn mentioned this pull request Jun 13, 2018
5 tasks
@5chdn 5chdn added this to the 1.12 milestone Jun 13, 2018
dvdplm added a commit that referenced this pull request Jun 13, 2018
* master:
  Check whether we need resealing in miner and unwrap has_account in account_provider (#8853)
  docker: Fix alpine build (#8878)
  Remove mac os installers etc (#8875)
  README.md: update the list of dependencies (#8864)
  Fix concurrent access to signer queue (#8854)
tavakyan referenced this pull request in C4Coin/c4coin-parity Jun 14, 2018
ordian added a commit to ordian/parity that referenced this pull request Jun 20, 2018
…rp_sync_on_light_client

* 'master' of https://github.com/paritytech/parity: (29 commits)
  Block 0 is valid in queries (openethereum#8891)
  fixed osx permissions (openethereum#8901)
  Atomic create new files with permissions to owner in ethstore (openethereum#8896)
  Add ETC Cooperative-run load balanced parity node (openethereum#8892)
  Add support for --chain tobalaba (openethereum#8870)
  fix some warns on nightly (openethereum#8889)
  Add new ovh bootnodes and fix port for foundation bootnode 3.2 (openethereum#8886)
  SecretStore: service pack 1 (openethereum#8435)
  Handle removed logs in filter changes and add geth compatibility field (openethereum#8796)
  fixed ipc leak, closes openethereum#8774 (openethereum#8876)
  scripts: remove md5 checksums (openethereum#8884)
  hardware_wallet/Ledger `Sign messages` + some refactoring (openethereum#8868)
  Check whether we need resealing in miner and unwrap has_account in account_provider (openethereum#8853)
  docker: Fix alpine build (openethereum#8878)
  Remove mac os installers etc (openethereum#8875)
  README.md: update the list of dependencies (openethereum#8864)
  Fix concurrent access to signer queue (openethereum#8854)
  Tx permission contract improvement (openethereum#8400)
  Limit the number of transactions in pending set (openethereum#8777)
  Use sealing.enabled to emit eth_mining information (openethereum#8844)
  ...
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well. M2-installer 📲 Installers for MacOS and Windows.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants