Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

rpc: cap gas limit of local calls #8943

Merged
merged 1 commit into from Jun 22, 2018
Merged

Conversation

andresilva
Copy link
Contributor

@andresilva andresilva commented Jun 21, 2018

Currently we have effectively unlimited gas for local calls, this leads to issues with unbounded loops in contracts that never end. I've decreased the cap to 500 million gas, which should still be more than enough for local calls.

Fixes #8904, fixes #8311.

@andresilva andresilva added A0-pleasereview 🤓 Pull request needs code review. F3-annoyance 💩 The client behaves within expectations, however this “expected behaviour” itself is at issue. M4-core ⛓ Core client code / Rust. labels Jun 21, 2018
@andresilva andresilva requested a review from debris June 21, 2018 11:33
@5chdn 5chdn added B0-patchthis and removed F3-annoyance 💩 The client behaves within expectations, however this “expected behaviour” itself is at issue. labels Jun 21, 2018
@5chdn 5chdn added this to the 1.12 milestone Jun 21, 2018
@debris
Copy link
Collaborator

debris commented Jun 22, 2018

@tomusdrw do you agree with this change?

@5chdn 5chdn requested a review from tomusdrw June 22, 2018 09:09
@tomusdrw tomusdrw added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Jun 22, 2018
@tomusdrw tomusdrw merged commit 6509e90 into master Jun 22, 2018
@tomusdrw tomusdrw deleted the andre/fix-gas-limit-local-call branch June 22, 2018 09:13
5chdn pushed a commit that referenced this pull request Jun 22, 2018
@5chdn 5chdn mentioned this pull request Jun 22, 2018
10 tasks
5chdn pushed a commit that referenced this pull request Jun 22, 2018
@5chdn 5chdn mentioned this pull request Jun 22, 2018
5chdn added a commit that referenced this pull request Jun 22, 2018
* parity-version: bump stable to 1.10.8

* Update ropsten.json (#8926)

* Update hardcoded headers (#8925)

* Update kovan.json

Update Kovan to block 7693549

* Update foundation.json

Updated to block #5812225

* Update ropsten.json

Update to 3465217

* Update ropsten.json

use tabs

* Update foundation.json

use tabs

* Update kovan.json

use tabs

* scripts: minor improvements (#8930)

* CI: enable 'latest' docker tag on master pipeline

* CI: mark both beta and stable as stable snap.

* CI: sign all windows binaries

* scripts: remove whisper target not available in stable

* Revert "Update hardcoded headers (#8925)"

This reverts commit e1dc515.

* scripts: fix gitlab strip binaries

* scripts: fix docker build tag on latest using master (#8952)

* rpc: cap gas limit of local calls (#8943)
dvdplm added a commit that referenced this pull request Jun 22, 2018
* master:
  rpc: cap gas limit of local calls (#8943)
  docs: update changelogs (#8931)
  ethcore: fix compilation when using slow-blocks or evm-debug features (#8936)
  fixed blooms dir creation (#8941)
  Update hardcoded headers (#8925)
ordian added a commit to ordian/parity that referenced this pull request Jun 27, 2018
…rp_sync_on_light_client

* 'master' of https://github.com/paritytech/parity:
  deps: bump fs-swap (openethereum#8953)
  Eliminate some more `transmute()` (openethereum#8879)
  Restrict vault.json permssion to owner and using random suffix for temp vault.json file (openethereum#8932)
  print SS.self_public when starting SS node (openethereum#8949)
  scripts: minor improvements (openethereum#8930)
  rpc: cap gas limit of local calls (openethereum#8943)
  docs: update changelogs (openethereum#8931)
  ethcore: fix compilation when using slow-blocks or evm-debug features (openethereum#8936)
  fixed blooms dir creation (openethereum#8941)
  Update hardcoded headers (openethereum#8925)
5chdn added a commit that referenced this pull request Jun 29, 2018
* parity-version: bump beta to 1.11.5

* Update ropsten.json (#8926)

* Update hardcoded headers (#8925)

* Update kovan.json

Update Kovan to block 7693549

* Update foundation.json

Updated to block #5812225

* Update ropsten.json

Update to 3465217

* Update ropsten.json

use tabs

* Update foundation.json

use tabs

* Update kovan.json

use tabs

* scripts: minor improvements (#8930)

* CI: enable 'latest' docker tag on master pipeline

* CI: mark both beta and stable as stable snap.

* CI: sign all windows binaries

* scripts: fix docker build tag on latest using master (#8952)

* rpc: cap gas limit of local calls (#8943)

* snap: downgrade rust to revision 1.26.2, ref snapcraft/+bug/1778530 (#8984)

* snap: downgrade rust to revision 1.26.2, ref snapcraft/+bug/1778530

* snap: use plugin rust

* Fix deadlock in blockchain. (#8977)

* Remove js-glue from workspace

This fixes test error on Rust 1.27 but also prevents js-glue from building itself. Builtin dapp users can still use
js-glue from crates.io.

* Fix Android build on beta (#9003)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well. M4-core ⛓ Core client code / Rust.
Projects
None yet
4 participants